Realtime Compositor: Immediately realize wrapped translations #113669

Merged

Omar Emara merged 3 commits from OmarEmaraDev/blender:wrapped-translations into main

2023-11-02 12:39:50 +01:00

Omar Emara commented

2023-10-13 13:21:05 +02:00

Member

This patch changes how wrapped translations are handled by the Realtime
Compositor. Previously, translations were always stored on the result
and delayed until automatically realized later. The wrapping status was
also stored to control this later automatic realization.

This patch changes that such that translations are immediately realized
for the axes that has enabled wrapping. Consequently, the image will not
get translated, but its content will, in a clip on one side, wrap on the
opposite side manner.

Another change is that wrapping information is no longer propagated to
future automatic realizations, so tilling or repeating an image is no
longer possible. An alternative method of repetition will be introduced
in a later patch.

This patch changes how wrapped translations are handled by the Realtime Compositor. Previously, translations were always stored on the result and delayed until automatically realized later. The wrapping status was also stored to control this later automatic realization. This patch changes that such that translations are immediately realized for the axes that has enabled wrapping. Consequently, the image will not get translated, but its content will, in a clip on one side, wrap on the opposite side manner. Another change is that wrapping information is no longer propagated to future automatic realizations, so tilling or repeating an image is no longer possible. An alternative method of repetition will be introduced in a later patch.

Omar Emara added the

labels 2023-10-13 13:21:05 +02:00

Omar Emara added 1 commit 2023-10-13 13:21:17 +02:00

090cc8d6e7 Realtime Compositor: Immediately realize wrapped translations

This patch changes how wrapped translations are handled by the Realtime
Compositor. Previously, translations were always stored on the result
and delayed until automatically realized later. The wrapping status was
also stored to control this later automatic realization.

This patch changes that such that translations are immediately realized
for the axes that has enabled wrapping. Consequently, the image will not
get translated, but its content will, in a clip on one side, wrap on the
opposite side manner.

Another change is that wrapping information is no longer propagated to
future automatic realizations, so tilling or repeating an image is no
longer possible. An alternative method of repetition will be introduced
in a later patch.

Omar Emara requested review from Sergey Sharybin 2023-10-13 13:21:49 +02:00

Sergey Sharybin commented

2023-11-01 12:10:44 +01:00

Owner

There is something strange going on when doing wrapping along one axis but not along the other. Attached file i've used to test, as well as F12 render with before and after this PR. It is as if the Y axis got double transform.

Can you look into it and confirm or deny the observation? :)

There is something strange going on when doing wrapping along one axis but not along the other. Attached file i've used to test, as well as F12 render with before and after this PR. It is as if the Y axis got double transform. Can you look into it and confirm or deny the observation? :)

3.4 MiB

3.3 MiB

compositor.blend

924 KiB

Omar Emara commented

2023-11-01 12:13:04 +01:00

Author

Member

@Sergey This is probably the same the issue fixed in: 3f49d286cc.
So it should be fixed once I merge main and update the patch.

@Sergey This is probably the same the issue fixed in: 3f49d286ccf9dc120ec40bdf0d0a479cb3a50f42. So it should be fixed once I merge main and update the patch.

Omar Emara added 2 commits 2023-11-02 10:41:53 +01:00

693a27b8ef Merge branch 'main' into wrapped-translations

76fe32de87 Fix double translations

Sergey Sharybin approved these changes 2023-11-02 11:48:45 +01:00

Omar Emara merged commit 1500a594ad into main

2023-11-02 12:39:50 +01:00

Omar Emara referenced this issue from a commit

2023-11-02 12:39:51 +01:00

Realtime Compositor: Immediately realize wrapped translations

Omar Emara deleted branch wrapped-translations

2023-11-02 12:39:52 +01:00

Omar Emara referenced this pull request

2024-04-07 13:39:13 +02:00

Image not tiling in viewport compositor using translate node set to wrap both axes #120354

Sign in to join this conversation.

No reviewers

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#113669

No description provided.