Mesh: Add versioning to convert old face maps to boolean attributes #113769

Merged
Hans Goudey merged 1 commits from HooglyBoogly/blender:face-maps-versioning-booleans into blender-v4.0-release 2023-10-17 09:17:17 +02:00
Member

See #105317

In 46cf093270, face maps were just converted to an integer
attribute. While the internal data remains the same that way, we lose
the names and some convenient methods of interaction. This commit
additionally converts each face map to a separate boolean attribute
using the old name. This does require that no attributes were using that
name already.

Each boolean attribute can be thought of as a selection, accessible in
geometry nodes and properly interpolated by mesh processing
algorithms. The selections no longer have to be unique, meaning
one face can be part of multiple selections.

See #105317 In 46cf09327001331c77bc, face maps were just converted to an integer attribute. While the internal data remains the same that way, we lose the names and some convenient methods of interaction. This commit additionally converts each face map to a separate boolean attribute using the old name. This does require that no attributes were using that name already. Each boolean attribute can be thought of as a selection, accessible in geometry nodes and properly interpolated by mesh processing algorithms. The selections no longer have to be unique, meaning one face can be part of multiple selections.
Hans Goudey added 1 commit 2023-10-16 12:26:17 +02:00
Mesh: Add versioning to convert old face maps to boolean attributes
Some checks failed
buildbot/vexp-code-patch-coordinator Build done.
1f47a2d716
See #105317

In 46cf093270, face maps were just converted to an integer
attribute. While the internal data remains the same that way, we lose
the names and some convenient methods of interaction. This commit
additionally converts each face map to a separate boolean attribute
using the old name. This does require that no attributes were using that
name already.
Hans Goudey added this to the 4.0 milestone 2023-10-16 12:27:30 +02:00
Hans Goudey requested review from Sergey Sharybin 2023-10-16 12:27:35 +02:00
Hans Goudey added the
Module
Modeling
label 2023-10-16 12:27:44 +02:00
Author
Member

@blender-bot build

@blender-bot build

On a code side seems all fine. Did you want some extra testing or something?

On a code side seems all fine. Did you want some extra testing or something?
Author
Member

It's working in my tests locally. Just wanted to run the buildbot tests and make sure you saw the change.

It's working in my tests locally. Just wanted to run the buildbot tests and make sure you saw the change.
Sergey Sharybin approved these changes 2023-10-16 14:09:48 +02:00
Hans Goudey merged commit 820f0c24c4 into blender-v4.0-release 2023-10-17 09:17:17 +02:00
Hans Goudey deleted branch face-maps-versioning-booleans 2023-10-17 09:17:18 +02:00
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Code Documentation
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
FBX
Interest
Freestyle
Interest
Geometry Nodes
Interest
glTF
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Asset System
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#113769
No description provided.