Fix: GPv3 depth buffer #113779

Merged
Falk David merged 6 commits from filedescriptor/blender:fix-gpv3-depth-buffer into main 2023-10-19 13:22:46 +02:00
Member

Resolves #113422.

The depth buffer was rendered to, but not correctly merged
with the scene depth buffer. This lead to, e.g. the object appearing
behind the grid.

This fixes the issue by rendering a "merge" pass.

Resolves #113422. The depth buffer was rendered to, but not correctly merged with the scene depth buffer. This lead to, e.g. the object appearing behind the grid. This fixes the issue by rendering a "merge" pass.
Falk David added 1 commit 2023-10-16 17:54:38 +02:00
3b09cd135d Fix: GPv3 depth buffer
The depth buffer was rendered to, but not correctly merged
with the scene depth buffer. This lead to, e.g. the object appearing
behind the grid.

This fixes the issue by rendering a "merge" pass.
Falk David requested review from Clément Foucault 2023-10-16 17:55:07 +02:00
Falk David changed title from Fix: GPv3 depth buffer to WIP: Fix: GPv3 depth buffer 2023-10-16 17:55:13 +02:00
Clément Foucault approved these changes 2023-10-18 17:32:24 +02:00
@ -91,6 +92,7 @@ class ObjectModule {
void begin_sync(Depsgraph *depsgraph, const View &main_view)
{
camera_forward_ = float3(main_view.viewinv()[2]);
camera_pos_ = float3(main_view.viewinv()[3]);

Use View::location() instead. Also maybe add forward to the View API.

Use `View::location()` instead. Also maybe add forward to the View API.
filedescriptor marked this conversation as resolved
Falk David added 3 commits 2023-10-18 17:39:50 +02:00
Clément Foucault approved these changes 2023-10-18 17:56:26 +02:00
Falk David changed title from WIP: Fix: GPv3 depth buffer to Fix: GPv3 depth buffer 2023-10-18 19:01:39 +02:00
Falk David added 1 commit 2023-10-18 19:01:42 +02:00
Clément Foucault approved these changes 2023-10-18 19:05:13 +02:00
@ -252,0 +286,4 @@
float4x4 bbox_mat = object_to_world *
from_loc_rot_scale<float4x4>(center, Quaternion::identity(), size);
float3 plane_normal;
if (DRW_view_is_persp_get(nullptr)) {

use view::is_persp().

use `view::is_persp()`.
filedescriptor marked this conversation as resolved
Falk David added 1 commit 2023-10-18 19:19:51 +02:00
buildbot/vexp-code-patch-coordinator Build done. Details
d3f40657b1
Use `view.is_persp()`
Falk David requested review from Clément Foucault 2023-10-18 19:20:33 +02:00
Clément Foucault approved these changes 2023-10-18 19:28:46 +02:00
Author
Member

@blender-bot build

@blender-bot build
Author
Member

@blender-bot build

@blender-bot build
Falk David merged commit 6281d9a039 into main 2023-10-19 13:22:46 +02:00
Falk David deleted branch fix-gpv3-depth-buffer 2023-10-19 13:22:48 +02:00
Falk David referenced this issue from a commit 2023-10-19 13:22:50 +02:00
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#113779
No description provided.