UI: Modifier Property Icons #113793

Harley Acheson · 2023-10-17T01:22:01+02:00

Harley Acheson commented

2023-10-17 01:22:01 +02:00

Add icons to some Modifier properties.

For example, changes this...

to this:

Add icons to some Modifier properties. --- For example, changes this... ![image](/attachments/2921d85e-c621-41d0-917f-6bc4ed8df052) to this: ![image](/attachments/00f6455f-b642-4441-a587-f453831dd26c)

image.png

393 KiB

image.png

24 KiB

image.png

24 KiB

Harley Acheson added 1 commit 2023-10-17 01:22:09 +02:00

b0dbdc8ad9 UI: UVProject Modifier UV Map Icon

In the UVProject Modifier change the UV Map icon from a dot to
ICON_GROUP_UVS.

Harley Acheson added this to the User Interface project 2023-10-17 01:22:21 +02:00

Harley Acheson requested review from Pablo Vazquez 2023-10-17 01:22:36 +02:00

Pablo Vazquez commented

2023-10-17 11:35:47 +02:00

Maybe this could become a more general task to cover other inputs missing the GROUP_UVS icon too?

Other modifiers that are missing the UV icon:

UV Warp
Warp
Explode (Particle UV)
Displace (when set to UV coordinates)

Other places I found on a quick look:

UV Map node (shading)
Dynamic Paint's Initial Color when using UV Texture
Fluid's Texture panel
Texture settings in the Mapping panel

I can also try and do this myself if you are busy, it's just digging around and looking for that one line in other places.

Maybe this could become a more general task to cover other inputs missing the `GROUP_UVS` icon too? Other modifiers that are missing the UV icon: * UV Warp * Warp * Explode (Particle UV) ![image](/attachments/3195d177-b684-4dbb-bc40-e58b4aff155d) * Displace (when set to UV coordinates) ![displace](/attachments/7b1919b8-d7b6-484d-98d8-9a3c431f9901) Other places I found on a quick look: * UV Map node (shading) ![uvmap node](/attachments/4736de6e-e956-47a4-b61a-8fbb7d9aeb5b) * Dynamic Paint's Initial Color when using UV Texture ![dynpaint](/attachments/51cd48e6-99f7-4086-9786-b0e16c4f6d35) * Fluid's Texture panel ![flow](/attachments/f11e3578-9d66-496f-b155-1bf784f4ea27) * Texture settings in the Mapping panel ![image](/attachments/0d71e1f3-6467-4a18-84ab-1dafde912138) I can also try and do this myself if you are busy, it's just digging around and looking for that one line in other places.

image.png

53 KiB

image.png

46 KiB

image.png

81 KiB

image.png

10 KiB

image.png

36 KiB

image.png

45 KiB

image.png

64 KiB

Harley Acheson commented

2023-10-17 19:18:38 +02:00

I can also try and do this myself if you are busy, it's just digging around and looking for that one line in other places.

Let me add some first. I think I can now see all the ones missing in the modifiers areas (lines containing both "uiItemPointerR" and ICON_NONE within source\blender\modifiers).

> I can also try and do this myself if you are busy, it's just digging around and looking for that one line in other places. Let me add some first. I think I can now see all the ones missing in the modifiers areas (lines containing both "uiItemPointerR" and ICON_NONE within source\blender\modifiers).

Harley Acheson changed title from ~~UI: UVProject Modifier UV Map Icon~~ to WIP UI: Modifier Property Icons

2023-10-17 19:24:41 +02:00

Harley Acheson added 1 commit 2023-10-17 20:46:23 +02:00

e0048de72b More missing modifier icons

Harley Acheson commented

2023-10-17 21:14:18 +02:00

@pablovazquez

Okay, this PR should now fix all those icons in the modifiers. However, I (so far) can't find your other two examples, UV Map node and the Texture settings in the Mapping panel.

@pablovazquez Okay, this PR should now fix all those icons in the modifiers. However, I (so far) can't find your other two examples, UV Map node and the Texture settings in the Mapping panel.

Harley Acheson changed title from ~~WIP UI: Modifier Property Icons~~ to UI: Modifier Property Icons

2023-10-17 21:45:05 +02:00

Pablo Vazquez requested changes 2023-10-18 12:22:03 +02:00

Pablo Vazquez left a comment

Only the change to use BONE_DATA instead of GROUP_BONE.

Only the change to use `BONE_DATA` instead of `GROUP_BONE`.

source/blender/modifiers/intern/MOD_uvwarp.cc Outdated

						
				@ -269,3 +269,3 @@

				  if (!RNA_pointer_is_null(&warp_obj_ptr) && RNA_enum_get(&warp_obj_ptr, "type") == OB_ARMATURE) {

				    PointerRNA warp_obj_data_ptr = RNA_pointer_get(&warp_obj_ptr, "data");

				    uiItemPointerR(col, ptr, "bone_from", &warp_obj_data_ptr, "bones", nullptr, ICON_NONE);

				    uiItemPointerR(col, ptr, "bone_from", &warp_obj_data_ptr, "bones", nullptr, ICON_GROUP_BONE);

Pablo Vazquez commented

2023-10-18 12:20:48 +02:00

This and all other uses of GROUP_BONE should be BONE_DATA. Since what the list shows is a single bone, not a group of bones (which are now called Bone Collections).

This and all other uses of `GROUP_BONE` should be `BONE_DATA`. Since what the list shows is a single bone, not a group of bones (which are now called Bone Collections).

Harley marked this conversation as resolved

Pablo Vazquez referenced this issue from a commit

2023-10-18 12:36:31 +02:00

UI: Use proper icon for nodes with UV Maps picker

Harley Acheson added 2 commits 2023-10-18 17:40:03 +02:00

62e5da2b18 Merge branch 'main' of projects.blender.org:blender/blender into UVProjectIcon

973f2569c1 ICON_GROUP_BONE -> ICON_BONE_DATA

Harley Acheson commented

2023-10-18 17:41:32 +02:00