Fix #113798: Weight paint gradient tool paints over hidden vertices #113825

Merged
Philipp Oeser merged 1 commits from lichtwerk/blender:113798 into blender-v4.0-release 2023-10-20 14:21:32 +02:00
Member

Note 0a0a29887d / 4c99043a85 were supposed to fix this.
This was mostly working, but verts could still obtain wrong weights
(most notably "outside" the gradient range).

Code from above commits would correctly skip hidden verts in
gradientVertUpdate__mapFunc.
However, gradientVertInit__mapFunc (called prior) already does
gradientVert_update once [not entirely sure why it does this, but
wouldnt want to remove the call there due to unforseen behavioral
changes] and we dont early out there.

So now move the check for hidden verts from
gradientVertUpdate__mapFunc to gradientVertInit__mapFunc and early
out (also saves us from doing other unneccessary stuff there).

Note 0a0a29887d70 / 4c99043a85bb were supposed to fix this. This was mostly working, but verts could still obtain wrong weights (most notably "outside" the gradient range). Code from above commits would correctly skip hidden verts in `gradientVertUpdate__mapFunc`. However, `gradientVertInit__mapFunc` (called prior) already does `gradientVert_update` once [not entirely sure why it does this, but wouldnt want to remove the call there due to unforseen behavioral changes] and we dont early out there. So now move the check for hidden verts from `gradientVertUpdate__mapFunc` to `gradientVertInit__mapFunc` and early out (also saves us from doing other unneccessary stuff there).
Philipp Oeser added 1 commit 2023-10-17 12:51:42 +02:00
02e4d6fba5 Fix #113798: Weight paint gradient tool paints over hidden vertices
Note 0a0a29887d / 4c99043a85 were supposed to fix this.
This was mostly working, but verts could still obtain wrong weights
(most notably "outside" the gradient range).

Code from above commits would correctly skip hidden verts in
`gradientVertUpdate__mapFunc`.
However, `gradientVertInit__mapFunc` (called prior) already does
`gradientVert_update` once [not entirely sure why it does this, but
wouldnt want to remove the call there due to unforseen behavioral
changes] and we dont early out there.

So now move the check for hidden verts from
`gradientVertUpdate__mapFunc` to `gradientVertInit__mapFunc` and early
out (also saves us from doing other unneccessary stuff there).
Philipp Oeser requested review from Sybren A. Stüvel 2023-10-17 12:51:56 +02:00
Philipp Oeser added this to the Animation & Rigging project 2023-10-17 12:52:08 +02:00
Philipp Oeser added the
Interest
Modeling
label 2023-10-17 12:52:16 +02:00
Philipp Oeser requested review from YimingWu 2023-10-17 12:52:26 +02:00
Philipp Oeser requested review from Hans Goudey 2023-10-17 12:52:36 +02:00
Sybren A. Stüvel approved these changes 2023-10-20 14:14:45 +02:00
Sybren A. Stüvel left a comment
Member

I haven't tested it, but it looks good to me.

I haven't tested it, but it looks good to me.
Philipp Oeser merged commit eed4f950d8 into blender-v4.0-release 2023-10-20 14:21:32 +02:00
Philipp Oeser deleted branch 113798 2023-10-20 14:21:37 +02:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser Project (Legacy)
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#113825
No description provided.