Fix #113798: Weight paint gradient tool paints over hidden vertices #113825

Philipp Oeser · 2023-10-17T12:51:27+02:00

Philipp Oeser commented

2023-10-17 12:51:27 +02:00

Note 0a0a29887d / 4c99043a85 were supposed to fix this.
This was mostly working, but verts could still obtain wrong weights
(most notably "outside" the gradient range).

Code from above commits would correctly skip hidden verts in
gradientVertUpdate__mapFunc.
However, gradientVertInit__mapFunc (called prior) already does
gradientVert_update once [not entirely sure why it does this, but
wouldnt want to remove the call there due to unforseen behavioral
changes] and we dont early out there.

So now move the check for hidden verts from
gradientVertUpdate__mapFunc to gradientVertInit__mapFunc and early
out (also saves us from doing other unneccessary stuff there).

Note 0a0a29887d70 / 4c99043a85bb were supposed to fix this. This was mostly working, but verts could still obtain wrong weights (most notably "outside" the gradient range). Code from above commits would correctly skip hidden verts in `gradientVertUpdate__mapFunc`. However, `gradientVertInit__mapFunc` (called prior) already does `gradientVert_update` once [not entirely sure why it does this, but wouldnt want to remove the call there due to unforseen behavioral changes] and we dont early out there. So now move the check for hidden verts from `gradientVertUpdate__mapFunc` to `gradientVertInit__mapFunc` and early out (also saves us from doing other unneccessary stuff there).

Philipp Oeser added 1 commit 2023-10-17 12:51:42 +02:00

02e4d6fba5 Fix #113798 : Weight paint gradient tool paints over hidden vertices

Note 0a0a29887d / 4c99043a85 were supposed to fix this.
This was mostly working, but verts could still obtain wrong weights
(most notably "outside" the gradient range).

Code from above commits would correctly skip hidden verts in
`gradientVertUpdate__mapFunc`.
However, `gradientVertInit__mapFunc` (called prior) already does
`gradientVert_update` once [not entirely sure why it does this, but
wouldnt want to remove the call there due to unforseen behavioral
changes] and we dont early out there.

So now move the check for hidden verts from
`gradientVertUpdate__mapFunc` to `gradientVertInit__mapFunc` and early
out (also saves us from doing other unneccessary stuff there).

Philipp Oeser requested review from Sybren A. Stüvel 2023-10-17 12:51:56 +02:00

Philipp Oeser added this to the Animation & Rigging project 2023-10-17 12:52:08 +02:00

Philipp Oeser added the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Fix #113798: Weight paint gradient tool paints over hidden vertices #113825