RNA: generate valid infinite float property default values #113854

Sybren A. Stüvel · 2023-10-17T18:29:41+02:00

Sybren A. Stüvel commented

2023-10-17 18:29:41 +02:00

In makesrna, generate valid default values for float properties, when those defaults are positive/negative infinity.

Blender would currently generate the strings inff and -inff, which are not valid C++. This PR changes that to std::numeric_limits<float>::infinity() and -std::numeric_limits<float>::infinity().

Context: the layered animation system (see #113594) will have animation layers with strips on them. It will have the concept of "infinite strips", where from a user's perspective there aren't even any strips at all, and the layer seems to directly contain the keys themselves. This is purely a UI distinction though, where we simply won't draw the outline of infinite strips. Being able to work with ±∞ as floating point values has clear advantages, as then the strip.frame_start and strip.frame_end properties will always "tell the truth".

This particular change is necessary to allow these values as defaults. It is not intended that users will have property sliders for these properties when their value is "infinite" (but rather a button 'make finite' or something along those lines), so interaction with the UI code will likely be minimal.

In `makesrna`, generate valid default values for float properties, when those defaults are positive/negative infinity. Blender would currently generate the strings `inff` and `-inff`, which are not valid C++. This PR changes that to `std::numeric_limits<float>::infinity()` and `-std::numeric_limits<float>::infinity()`. Context: the layered animation system (see #113594) will have animation layers with strips on them. It will have the concept of "infinite strips", where from a user's perspective there aren't even any strips at all, and the layer seems to directly contain the keys themselves. This is purely a UI distinction though, where we simply won't draw the outline of infinite strips. Being able to work with ±∞ as floating point values has clear advantages, as then the `strip.frame_start` and `strip.frame_end` properties will always "tell the truth". This particular change is necessary to allow these values as defaults. It is not intended that users will have property sliders for these properties when their value is "infinite" (but rather a button 'make finite' or something along those lines), so interaction with the UI code will likely be minimal.

Sybren A. Stüvel added the

Module

Core

label 2023-10-17 18:29:41 +02:00

Sybren A. Stüvel added 1 commit 2023-10-17 18:29:52 +02:00

b559d8676c RNA: generate valid infinite float property default values

In `makesrna`, generate valid default values for float properties, when
those defaults are positive/negative infinity.

Blender would currently generate the strings `inff` and `-inff`, which
are not valid C++. This PR changes that to
`std::numeric_limits<float>::infinity()` and
`-std::numeric_limits<float>::infinity()`.

Sybren A. Stüvel requested review from Bastien Montagne 2023-10-17 18:30:08 +02:00

Sybren A. Stüvel added this to the Animation & Rigging project 2023-10-17 18:30:14 +02:00

Bastien Montagne commented

2023-10-18 10:01:00 +02:00

That looks good in general, since current behavior is broken anyway. But have you also checked how the python binding code deals with these new float values?

Sybren A. Stüvel commented

2023-10-19 12:49:20 +02:00

Yes, it works just fine. I can assign strip.frame_start = -inf just fine.

Even the sliders display the values pretty well:

Editing doesn't work properly (the hard limits are still FLT_MAX), but that's not for this PR. I just wanted to be sure that nothing would crash when displaying those values, and that's all 👌 .

Yes, it works just fine. I can assign `strip.frame_start = -inf` just fine. Even the sliders display the values pretty well: ![Screenshot of Blender, showing `-inf` and `inf` as slider values](/attachments/4a24253b-c43c-4189-a48a-1cd920b19486) Editing doesn't work properly (the hard limits are still `FLT_MAX`), but that's not for this PR. I just wanted to be sure that nothing would crash when displaying those values, and that's all 👌 .

image.png

7.3 KiB

Bastien Montagne approved these changes 2023-10-19 13:57:43 +02:00

Bastien Montagne left a comment

LGTM then, thx.

Sybren A. Stüvel referenced this issue from a commit

2023-10-19 14:15:32 +02:00

RNA: generate valid infinite float property default values

Sybren A. Stüvel manually merged commit 395ac4c41f into main

2023-10-19 14:55:58 +02:00

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

RNA: generate valid infinite float property default values #113854