Fix: USD Export: Calculate extents properly for lights #113910
No reviewers
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#113910
Loading…
Reference in New Issue
No description provided.
Delete Branch "CharlesWardlaw/blender:bugfix/light_bounds"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Lights without calculated Extents are not considered correct USD. This is now possible with the APIs provided by recent USD versions.
Based on the API documentation, this makes sense to me, and the code looks good.
USD: Small change to make sure lights have their Extents properly calculated.to Fix: USD Export: Calculate extents properly for lightsThough since this is a fix, I believe it should target the 4.0 branch.
Fix: USD Export: Calculate extents properly for lightsto Fix: USD Export: Calculate extents properly for lightsI changed the target-- Please let me know if you need anything else.
Just changing the target isn't enough, you have to rebase the commits. Check out the "Rebasing a Pull Request" instructions here: https://wiki.blender.org/wiki/Tools/Pull_Requests
Ahh just noticed I need to rebase now -- give me a few.
cf75b20123
tod66f96df09
@blender-bot build
This looks good. Thank you!
Due to an oversight on my part, this wasn't merged in time into the 4.0 release branch. My apologies.
This pull can now be merged into main. Since this change is small, I will commit it manually into main, rather than requiring @CharlesWardlaw to rebase the pull yet again.
Committed to main in
e6ff1348cb
Pull request closed