Fix #95045: UI: keymap header in preferences truncated when filtering #114012

Merged

Harley Acheson merged 1 commits from pioverfour/blender:dp_make_keymap_title_wider into main

2023-11-29 22:36:19 +01:00

Damien Picard commented

2023-10-21 18:59:17 +02:00

Member

The UI displaying keymaps in the User Preferences is different
depending on whether the filter is being used or not. If it is used,
the header for each keymap is cut short using the default window size.
Even resizing the window has little effect. For instance, searching
for "grease" will display:

Grease Pencil ...
Grease Pencil ...
Grease Pencil ...

instead of:

Grease Pencil Stroke Edit Mode
Grease Pencil Stroke Paint Mode
Grease Pencil Stroke Paint (Draw brush)

This commit changes the UI so that the title takes up all available
space. It reuses the code from the case where the filter is empty.
This makes the Restore button narrower, matching the no-filter
version.

Here is a comparison, with the UI without any filter as well, to compare the Restore button width:

Before	After	Before (no-filter)

The UI displaying keymaps in the User Preferences is different depending on whether the filter is being used or not. If it is used, the header for each keymap is cut short using the default window size. Even resizing the window has little effect. For instance, searching for "grease" will display: - Grease Pencil ... - Grease Pencil ... - Grease Pencil ... instead of: - Grease Pencil Stroke Edit Mode - Grease Pencil Stroke Paint Mode - Grease Pencil Stroke Paint (Draw brush) This commit changes the UI so that the title takes up all available space. It reuses the code from the case where the filter is empty. This makes the Restore button narrower, matching the no-filter version. ----- Here is a comparison, with the UI without any filter as well, to compare the Restore button width: | Before | After | Before (no-filter) | |--------------------------------------------------------------------------------------|-------------------------------------------------------------------------------------|-----------------------------------------------------------------------------------| | ![keymap_search_title_before.png](/attachments/63fa2982-b06f-4fa9-b962-757b110773cd) | ![keymap_search_title_after.png](/attachments/d7d0d99a-df5d-419a-a3fb-ea596e14527a) | ![keymap_search_title_ref.png](/attachments/67240b86-47eb-4b08-909f-f92bb108dafc) |

keymap_search_title_ref.png

20 KiB

keymap_search_title_before.png

99 KiB

keymap_search_title_after.png

103 KiB

Damien Picard added the

label 2023-10-21 18:59:17 +02:00

Damien Picard added 1 commit 2023-10-21 18:59:27 +02:00

a43c3d6bae UI: let keymap header take more horizontal space when filtering

The UI displaying keymaps in the User Preferences is different
depending on whether the filter is being used or not. If it is used,
the header for each keymap is cut short using the default window size.
Even resizing the window has little effect. For instance, searching
for "grease" will display:

- Grease Pencil ...
- Grease Pencil ...
- Grease Pencil ...

instead of:

- Grease Pencil Stroke Edit Mode
- Grease Pencil Stroke Paint Mode
- Grease Pencil Stroke Paint (Draw brush)

This commit changes the UI so that the title takes up all available
space. It reuses the code from the case where the filter is empty.
This makes the Restore button narrower, matching the no-filter
version.

dupoxy commented

2023-10-21 20:40:02 +02:00

Contributor

This fix : #112057

This fix : #112057

Damien Picard changed title from ~~UI: let keymap header take more horizontal space when filtering~~ to Fix #112057: keymap header in preferences truncated when filtering

2023-10-21 20:51:32 +02:00

Damien Picard changed title from ~~Fix #112057: keymap header in preferences truncated when filtering~~ to Fix #112057: keymap header in preferences truncated when filtering

2023-10-21 20:52:00 +02:00

pioverfour changed target branch from main to blender-v4.0-release

2023-10-21 20:52:02 +02:00

Damien Picard changed title from ~~Fix #112057: keymap header in preferences truncated when filtering~~ to Fix : UI: keymap header in preferences truncated when filtering

2023-10-21 21:02:07 +02:00

Damien Picard changed title from ~~Fix : UI: keymap header in preferences truncated when filtering~~ to Fix: UI: keymap header in preferences truncated when filtering

2023-10-22 09:56:35 +02:00

Damien Picard changed title from ~~Fix: UI: keymap header in preferences truncated when filtering~~ to Fix #95045: UI: keymap header in preferences truncated when filtering

2023-10-23 12:09:26 +02:00

Iliya Katushenock added this to the User Interface project 2023-11-20 17:16:55 +01:00

Iliya Katushenock removed the

label 2023-11-20 17:17:01 +01:00

Harley Acheson requested review from Harley Acheson 2023-11-20 18:11:55 +01:00

Harley changed target branch from blender-v4.0-release to main

2023-11-29 22:32:44 +01:00

Harley Acheson approved these changes 2023-11-29 22:33:40 +01:00

Harley Acheson left a comment

Member

works great!

works great!

Harley Acheson merged commit 3f5fd74953 into main

2023-11-29 22:36:19 +01:00

Harley Acheson referenced this issue from a commit

2023-11-29 22:36:22 +01:00

Fix #95045: UI: keymap header in preferences truncated when filtering

Sign in to join this conversation.

No reviewers

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#114012

No description provided.