BLF: Improved Cached Fallback Font Setup #114018

Harley Acheson · 2023-10-22T02:59:38+02:00

Harley Acheson commented

2023-10-22 02:59:38 +02:00

Changes to FontBLF initialization so that the cached fallback fonts,
which remain faceless until needed, get all required setup.
Otherwise they are not kerned and we also don't get metrics from them.

This is actually an old PR on Phab. https://archive.blender.org/developer/D15844

This largely just breaks up blf_ensure_face into two parts so that some setup can be called from it and also from the blf_cache_face_requester callback.

We distribute some fonts that are specific to particular languages or uses and we therefore do not want to fully set them up until they are actually used. But with the addition of the FreeType Caching subsystem those fonts do not get a Face until the caching system itself initiates it and we are informed via a callback. At that point calling blf_ensure_face does nothing since the face now exists. This means that they do not get some setup that they would have gotten if caching wasn't enabled or if they were not created to be initially faceless.

Without this fix, fallback fonts will not do kerning if the font supports that, but none of these fonts are used for Latin text anyway. They also will not support variable font features if they are of that type. And we would not get font metrics from them. All these things are now becoming more important.

Changes to FontBLF initialization so that the cached fallback fonts, which remain faceless until needed, get all required setup. Otherwise they are not kerned and we also don't get metrics from them. --- This is actually an old PR on Phab. https://archive.blender.org/developer/D15844 This largely just breaks up `blf_ensure_face` into two parts so that some setup can be called from it and also from the `blf_cache_face_requester` callback. We distribute some fonts that are specific to particular languages or uses and we therefore do not want to fully set them up until they are actually used. But with the addition of the FreeType Caching subsystem those fonts do not get a Face until the caching system itself initiates it and we are informed via a callback. At that point calling blf_ensure_face does nothing since the face now exists. This means that they do not get some setup that they would have gotten if caching wasn't enabled or if they were not created to be initially faceless. Without this fix, fallback fonts will not do kerning if the font supports that, but none of these fonts are used for Latin text anyway. They also will not support variable font features if they are of that type. And we would not get font metrics from them. All these things are now becoming more important.

Harley Acheson added 1 commit 2023-10-22 02:59:49 +02:00

buildbot/vexp-code-patch-coordinator Build done. Details

6039290c33 BLF: Improved Cached Fallback Font Setup

Changes to FontBLF initialization so that the cached fallback fonts
- which remain faceless until needed - get all required setup.
Otherwise they are not kerned and we also don't get metrics from them.

---

This is actually an old PR on Phab. https://archive.blender.org/developer/D15844

This largely just breaks up `blf_ensure_face` into two parts so that some setup can be called from it and also from the `blf_cache_face_requester` callback.

We distribute some fonts that are specific to particular languages or uses and we therefore do not want to fully set them up until they are actually used. But with the addition of the FreeType Caching subsystem those fonts do not get a Face until the caching system itself initiates it and we are informed via a callback. At that point calling blf_ensure_face does nothing since the face now exists. This means that they do not get some setup that they would have gotten if caching wasn't enabled or if they were not created to be initially faceless.

Without this fix, fallback fonts will not do kerning if the font supports that, but none of these fonts are used for Latin text anyway. They also will not support variable font features if they are of that type. And we would not get font metrics from them. All these things are now becoming more important.

Harley Acheson added this to the User Interface project 2023-10-22 03:03:23 +02:00

Harley Acheson commented

2023-10-22 03:03:28 +02:00

@blender-bot build

Harley Acheson merged commit b53111e935 into main

2023-10-22 03:55:07 +02:00

Harley Acheson referenced this issue from a commit

2023-10-22 03:55:08 +02:00

BLF: Improved Cached Fallback Font Setup

Harley Acheson deleted branch FontSetup

2023-10-22 03:55:09 +02:00

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

BLF: Improved Cached Fallback Font Setup #114018