PyAPI: Allow prop collection raw array read access for non-editable props #114063
No reviewers
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#114063
Loading…
Reference in New Issue
No description provided.
Delete Branch "Mysteryem/blender:prop_collection_raw_read_access"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Non-editable prop collection items would always fall back to the slower
loop in rna_raw_access.
This patch changes RNA_property_collection_raw_array to only fail with
non-editable items when intending to set values, allowing for the faster
raw array access to occur when reading values in rna_raw_access.
This brings the Python API bpy_prop_collection.foreach_get performance
of Mesh.vertex_normals/polygon_normals/corner_normals up to the same
speed as generic FLOAT_VECTOR attributes with the same domains.
Given a mesh with 393216 corners:
Using foreach_get with the "vector" prop and a compatible buffer object:
Using foreach_get with the "vector" prop and a Python list:
Nice find! Besides picky note below, LGTM, thanks!
@ -456,2 +454,2 @@
PropertyRNA *itemprop,
RawArray *array);
int RNA_property_collection_raw_array(
PointerRNA *ptr, PropertyRNA *prop, PropertyRNA *itemprop, int set, RawArray *array);
Would rather use
bool
when adding new boolean parameters. usage ofint
for these is only for historical reasons, and (still) needs to be cleaned up...@blender-bot build
@blender-bot build
I haven't been able to get the test_load_exr failure on this PR branch at all, but I did get it once on another branch that was created from
main
at the same point in time, so maybe it was just a bad point in time to create this PR branch at. I've mergedmain
into this PR branch now, so hopefully that fixes the test failure (still has not failed for me when running the tests locally).I don't think that test failure was related to this patch indeed.
Will re-run it just in case.
@blender-bot build
@blender-bot build linux