Vulkan: Separate DataTransfer, Compute, Graphics Commands #114104

Merged

Jeroen Bakker merged 23 commits from Jeroen-Bakker/blender:vulkan/specialized-command-buffers into main

2023-10-30 14:21:24 +01:00

Jeroen Bakker commented

2023-10-24 14:50:56 +02:00

Member

Goal is to reduce the number of command buffer flushes by tracking what is
happening in the different command queues. This is an initial step towards
advanced queue-ing strategies.

The new (intermediate) strategy records commands to different command
buffers based on what they do. There is a command buffer for data transfers,
compute pipelines and graphics pipelines.

When a compute command is recorded it ensures that all graphic commands
are finished. When a graphic command is recorded it ensures all compute
commands are finished. When a graphic or compute command is scheduled
all recorded data transfer commands are scheduled as well.

Some improvements are expected as multiple compute and data transfers
commands can now be scheduled at the same time and don't need to unbind
and rebind render passes. Especially when using EEVEE-Next which is
compute centric the performance change is visible for the user.

Goal is to reduce the number of command buffer flushes by tracking what is happening in the different command queues. This is an initial step towards advanced queue-ing strategies. The new (intermediate) strategy records commands to different command buffers based on what they do. There is a command buffer for data transfers, compute pipelines and graphics pipelines. When a compute command is recorded it ensures that all graphic commands are finished. When a graphic command is recorded it ensures all compute commands are finished. When a graphic or compute command is scheduled all recorded data transfer commands are scheduled as well. Some improvements are expected as multiple compute and data transfers commands can now be scheduled at the same time and don't need to unbind and rebind render passes. Especially when using EEVEE-Next which is compute centric the performance change is visible for the user.

Jeroen Bakker added this to the 4.1 milestone 2023-10-24 14:50:56 +02:00

Jeroen Bakker added the

label 2023-10-24 14:50:56 +02:00

Jeroen Bakker self-assigned this 2023-10-24 14:50:56 +02:00

Jeroen Bakker added 1 commit 2023-10-24 14:51:06 +02:00

b2e333fb5d Vulkan: Separate DataTransfer, Compute, Graphics Commands

Jeroen Bakker added this to the EEVEE & Viewport project 2023-10-24 14:51:15 +02:00

Jeroen Bakker added 1 commit 2023-10-24 15:01:27 +02:00

17af489184 Use correct stage flags

Kazashi Yoshioka commented

2023-10-24 15:21:51 +02:00

Contributor

Hello, good job. An important issue in submission is distributing the queue.
Drawing eevee and drawing multiple windows must be executed in multiple threads, so as is, it will always crash. Because it is not possible to use a single queue with multiple threads.
My implementation ended up being that for now it's good to do the queue selection in ContextVK.
Although it is only available on Windows, the implementation is as follows.
f9367b534a/intern/ghost/intern/GHOST_ContextVK.cc (L415)

Hello, good job. An important issue in submission is distributing the queue. Drawing eevee and drawing multiple windows must be executed in multiple threads, so as is, it will always crash. Because it is not possible to use a single queue with multiple threads. My implementation ended up being that for now it's good to do the queue selection in ContextVK. Although it is only available on Windows, the implementation is as follows. https://projects.blender.org/vnapdv/blender/src/commit/f9367b534a326ccc4809cb643d029362b6045d92/intern/ghost/intern/GHOST_ContextVK.cc#L415

Jeroen Bakker added 11 commits 2023-10-24 22:25:38 +02:00

a31882d0cf Cycles: oneAPI: fix device compilation with latest MSVC

<algorithm> header include is missing from some sycl headers, this will
be fixed upstream with https://github.com/intel/llvm/pull/10424,
meanwhile, we work around it by including it directly.

05f5908d5d Cleanup: Strict compiler arning

Unused function argument in the Metal framebuffer.

1812675388 Cleanup: Suppress strict compiler warning for external code

The new Clang which came with XCode 15 introduced the new
warning: -Wsingle-bit-bitfield-constant-conversion. It is a bit
too noisy in the Bullet code.

Since the warning is in the code which we do not maintain suppress
it similar to other similar warnings.

Pull Request: #113136

c3c5432678 GL: Remove Apple platform specific workarounds

We don't ship with OpenGL anymore on Mac platform.
The build option is not even available anymore.

This removes any reference to Apple or Mac in the
Opengl module.

Note that I left the depth_blitting_workaround
even if it originaly meant for Mac because it
might be still useful for other hardware.

Pull Request: #113126

bb480f1fdd Merge branch 'main' of projects.blender.org:Jeroen-Bakker/blender

6855ec5826 Merge branch 'main' of projects.blender.org:Jeroen-Bakker/blender

a829f531f0 Merge branch 'main' of projects.blender.org:blender/blender

dd5b84ac97 Merge branch 'main' of projects.blender.org:blender/blender

9d7bff33e0 Merge branch 'main' of projects.blender.org:Jeroen-Bakker/blender

0d415f8a82 Merge branch 'main' of projects.blender.org:blender/blender

77cd4cffba Merge branch 'main' into vulkan/specialized-command-buffers

Jeroen Bakker added 2 commits 2023-10-25 21:57:32 +02:00

f29a5e8771 First step in reducing code

0592d76ce1 deduplicated most commands

Jeroen Bakker added 2 commits 2023-10-27 16:36:20 +02:00

a758f43cbe commit

1e0fbdd999 Fixing framebuffer rebinding

Jeroen Bakker added 1 commit 2023-10-27 16:56:49 +02:00

ee0644fbff Commit

Jeroen Bakker added 2 commits 2023-10-30 10:49:02 +01:00

119cde09b6 Merge branch 'main' into vulkan/specialized-command-buffers

bb3537541e Fix small order issues

Jeroen Bakker changed title from ~~WIP: Vulkan: Separate DataTransfer, Compute, Graphics Commands~~ to Vulkan: Separate DataTransfer, Compute, Graphics Commands

2023-10-30 10:55:50 +01:00

Jeroen Bakker changed title from ~~Vulkan: Separate DataTransfer, Compute, Graphics Commands~~ to Vulkan: Seperate DataTransfer, Compute, Graphics Commands

2023-10-30 10:55:58 +01:00

Jeroen Bakker changed title from ~~Vulkan: Seperate DataTransfer, Compute, Graphics Commands~~ to Vulkan: Separate DataTransfer, Compute, Graphics Commands

2023-10-30 10:56:13 +01:00

Jeroen Bakker added 3 commits 2023-10-30 13:38:14 +01:00

fa23974a1f Remove references to device.

7830597218 Remove queue handle.

1c54c9c1ea Do data transfers together with compute/graphics

Jeroen Bakker merged commit f35b0373d6 into main

2023-10-30 14:21:24 +01:00

Jeroen Bakker referenced this issue from a commit

2023-10-30 14:21:25 +01:00

Vulkan: Separate DataTransfer, Compute, Graphics Commands

Sign in to join this conversation.

No reviewers

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#114104

No description provided.