Fix #112716: Custom sockets ignore draw_color method #114148
No reviewers
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#114148
Loading…
Reference in New Issue
No description provided.
Delete Branch "OmarEmaraDev/blender:fix-112716"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Customs sockets always ignore their draw_color method and are always
drawn using a magenta color.
This is a regression that was introduced in
e071288ab2
. The commit usedthe simple variant even for drawing nodes where a context is available.
So this patch mostly reverts those changes.
@blender-bot build
Oops, menat to tag the report (not the PR)
Looks reasonable, especially since it indeed mainly just reverts some changes. The socket color in the interface panel is still correctly drawn.
Fix #112716: Custom sockets ignore draw_color methodto Fix #112716: Custom sockets ignore draw_color methodbc913a84cb
toe31fc86268
This in turn broke the sockets using
draw_color_simple()
. You can reproduce by running thecustom_nodes.py
template. Not sure if this is a bug or if the template should be reverted to usingdraw_color()
?@pioverfour If you don't make use of node interfaces, then you should implement the
draw_color
method, if you do, you will likely just need to implement both methods.Perhaps we should fallback to the simple variant if the context variant is not found, but this is probably not considered a bug. I will submit a patch for that.
Yes, the simple variant should be used as a fallback, let me know when you have the patch ready.