GPv3: Multi-frame editing #114283
No reviewers
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#114283
Loading…
Reference in New Issue
No description provided.
Delete Branch "filedescriptor/blender:gpv3-multi-frame-editing"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Adds a new scene tool setting
use_grease_pencil_multi_frame_editing
.The
foreach_*_drawing
functions are moved to theed::greasepencil
namespace in the editor, since they are now context sensitive and depend on the toolsetting. They don't belong in the core anymore.0305ced807
to0c9884bc96
WIP: GPv3: Multi-frame editingto GPv3: Multi-frame editing@blender-bot build
Looks good! Worth an extra check for thread safety in callbacks and switching
return
tocontinue
in the non-parallel cases.@ -1840,1 +1828,3 @@
blender::Span<const Layer *> layers = grease_pencil.layers();
using namespace blender;
std::optional<Bounds<float3>> bounds;
Span<const bke::greasepencil::Layer *> layers = this->layers();
const Span
@ -285,2 +283,2 @@
struct GPUVertBuf *DRW_cache_grease_pencil_position_buffer_get(struct Object *ob, int cfra);
struct GPUVertBuf *DRW_cache_grease_pencil_color_buffer_get(struct Object *ob, int cfra);
struct GPUBatch *DRW_cache_grease_pencil_get(struct Object *ob, const struct Scene *scene);
struct GPUBatch *DRW_cache_grease_pencil_edit_points_get(struct Object *ob,
Think the scene can come before the object here, since it's at a higher level / more constant
@ -2798,3 +2801,3 @@
/* In weight-paint, we use selected bone to select vertex-group.
* In this case the active object mustn't change as it would leave weight-paint mode. */
* In this case the active object mustn't change as it would leave weight-paint mode.
Necessary changes to formatting here? Maybe not
@ -881,0 +887,4 @@
return;
}
GreasePencil *grease_pencil = static_cast<GreasePencil *>(active_object->data);
DEG_id_tag_update(&grease_pencil->id, ID_RECALC_GEOMETRY);
ID_RECALC_SHADING
might be better here, to avoid recalculating the object unnecessarily@filedescriptor One important point: In GPv2 the active frame always is considered as selected. Now if you enable multiframe but the actual frame is not selected, the strokes disappear.