Fix: Remove support for node tool data-block inputs for 4.0 #114621

Hans Goudey · 2023-11-08T10:36:52+01:00

Hans Goudey commented

2023-11-08 10:36:52 +01:00

There are two bugs with data-block inputs currently. One is #113383,
where clicking the "Clear" button on the data-block picker closes the
redo panel. The worse issue is that storing pointer properties in
operators isn't safe at all. Deleting the data-block doesn't clear
the pointer property in operator storage, for example.

The proper solution is to reuse some code from the existing data-block
picker but back it with a session_uuid integer property instead of an
actual pointer. This makes lookups safe without depending on the name.
However, doing that for 4.0 is too risky, so for now we will just not
support data-block inputs in the redo panel.

There are two bugs with data-block inputs currently. One is #113383, where clicking the "Clear" button on the data-block picker closes the redo panel. The worse issue is that storing pointer properties in operators isn't safe at all. Deleting the data-block doesn't clear the pointer property in operator storage, for example. The proper solution is to reuse some code from the existing data-block picker but back it with a `session_uuid` integer property instead of an actual pointer. This makes lookups safe without depending on the name. However, doing that for 4.0 is too risky, so for now we will just not support data-block inputs in the redo panel.

Hans Goudey added 1 commit 2023-11-08 10:37:05 +01:00

0b365e8629 Fix: Remove support for node tool data-block inputs for 4.0

There are two bugs with data-block inputs currently. One is #113383,
where clicking the "Clear" button on the data-block picker closes the
redo panel. The worse issue is that storing pointer properties in
operators isn't safe at all. Deleting the data-block doesn't clear
the pointer property in operator storage, for example.

The proper solution is to reuse some code from the existing data-block
picker but back it with a `session_uuid` integer property instead of an
actual pointer. This makes lookups safe without depending on the name.
However, doing that for 4.0 is too risky, so for now we will just not
support data-block inputs in the redo panel.

Hans Goudey requested review from Jacques Lucke 2023-11-08 10:38:00 +01:00

Hans Goudey added the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Fix: Remove support for node tool data-block inputs for 4.0 #114621