Geometry Nodes: Support top-level instance meshes in boolean node #114632

Merged
Hans Goudey merged 3 commits from HooglyBoogly/blender:fix-boolean-bad-4.0 into blender-v4.0-release 2023-11-09 11:54:51 +01:00
Member

During the 2.93 to 3.0 transition, instance handling was made more
explicit in general. However, we forgot to change the boolean node,
which still implicitly gathered all the instanced meshes and fed them
to the boolean algorithm separately. We waited for the next breaking
release, 4.0 to "correct" this, and did it in fc06a471f1.
However, in that commit it was assumed that the "Self Intersection"
mode would be able to address the use case. The idea was also to push
some complexity outside of the boolean code, which is already one of
the more complex areas in Blender. Though it's possible to have a
"Group ID" or "Shape ID" input in the future as well, it's also
reasonable to expect some instances to be processed by the node,
even though it isn't quite consistent.

This commit makes a compromise by processing meshes contained by
top-level instances. We do it at this stage of the release to avoid the
breaking change.

During the 2.93 to 3.0 transition, instance handling was made more explicit in general. However, we forgot to change the boolean node, which still implicitly gathered all the instanced meshes and fed them to the boolean algorithm separately. We waited for the next breaking release, 4.0 to "correct" this, and did it in fc06a471f174368bed2b. However, in that commit it was assumed that the "Self Intersection" mode would be able to address the use case. The idea was also to push some complexity outside of the boolean code, which is already one of the more complex areas in Blender. Though it's possible to have a "Group ID" or "Shape ID" input in the future as well, it's also reasonable to expect some instances to be processed by the node, even though it isn't quite consistent. This commit makes a compromise by processing meshes contained by top-level instances. We do it at this stage of the release to avoid the breaking change.
Hans Goudey added 1 commit 2023-11-08 14:31:37 +01:00
buildbot/vexp-code-patch-coordinator Build done. Details
c39d19ea57
Geometry Nodes: Support top-level instance meshes in boolean node
During the 2.93 to 3.0 transition, instance handling was made more
explicit in general. However, we forgot to change the boolean node,
which still implicitly gathered all the instanced meshes and fed them
to the boolean algorithm separately. We waited for the next breaking
release, 4.0 to "correct" this, and did it in fc06a471f1.
However, in that commit it was assumed that the "Self Intersection"
mode would be able to address the use case. The idea was also to push
some complexity outside of the boolean code, which is already one of
the more complex areas in Blender. Though it's possible to have a
"Group ID" or "Shape ID" input in the future as well, it's also
reasonable to expect some instances to be processed by the node,
even though it isn't quite consistent.

This commit makes a compromise by processing meshes contained by
top-level instances. We do it at this stage of the release to avoid the
breaking change.
Hans Goudey requested review from Jacques Lucke 2023-11-08 14:31:47 +01:00
Hans Goudey requested review from Simon Thommes 2023-11-08 14:31:47 +01:00
Hans Goudey added the
Interest
Geometry Nodes
label 2023-11-08 14:31:51 +01:00
Hans Goudey added this to the 4.0 milestone 2023-11-08 14:31:54 +01:00
Hans Goudey added this to the Nodes & Physics project 2023-11-08 14:32:05 +01:00
Author
Member

@blender-bot build

@blender-bot build
Jacques Lucke approved these changes 2023-11-09 10:44:09 +01:00
Simon Thommes approved these changes 2023-11-09 11:42:55 +01:00

Should versioning code from fc06a471f1 be reverted too?

Should versioning code from fc06a471f174368bed2b be reverted too?
Hans Goudey added 2 commits 2023-11-09 11:53:57 +01:00
Hans Goudey merged commit 16553c2a44 into blender-v4.0-release 2023-11-09 11:54:51 +01:00
Hans Goudey deleted branch fix-boolean-bad-4.0 2023-11-09 11:54:52 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#114632
No description provided.