Fix: Incorrect calculation of meta strip range #114644

ok what · 2023-11-08T21:36:12+01:00

ok what commented

2023-11-08 21:36:12 +01:00

The meta strip range was calculated before the effect strip range was updated. To the user this appeared as the meta strip erratically jumping to another location in the timeline when transforming it, under specific conditions.

Ways to reproduce

These are some examples of the bugs this PR fixes. There are other possible ways to trigger this bug, similar to the ones listed below, which involve changing the length or start frame of a strip, which has an effect strip applied to it, which is also inside a meta strip.

Add a color strip at frame 50
Add a glow effect on the color strip
Group them inside a meta strip
Quickly move the color strip to the right
Exit the meta strip and move the meta strip.
The strip "jumps" backward.

Add a movie strip at frame 50
Add a glow effect on the movie strip
Group them inside a meta strip
Entire retiming mode on the movie strip and quickly move the left retiming key to the right
Exit the meta strip and move the meta strip.
The strip "jumps" backward.

This calculation order is also in the code for adding an effect strip. If the effect strip is added on the color strip before grouping, the bug doesn't appear:

Add a color strip on frame 50
Group it inside a meta strip
Go inside the meta strip and add a glow effect on the color strip
Exit the meta strip and move the meta strip.
The strip "jumps" to frame 0.

Review notes

SEQ_time_update_meta_strip_range(...) function:

Effect strips which depend on other strips are included in the calculation for the meta strip range. The code could be changed to exclude them. Doing that might obscure other bugs though.
I'm not sure if the calculation order of SEQ_time_update_meta_strip_range and seq_time_update_effects_strip_range has any impact in this function, but it could be changed along with the other ones in this PR for consistency.

The meta strip range was calculated before the effect strip range was updated. To the user this appeared as the meta strip erratically jumping to another location in the timeline when transforming it, under specific conditions. ### Ways to reproduce These are some examples of the bugs this PR fixes. There are other possible ways to trigger this bug, similar to the ones listed below, which involve changing the length or start frame of a strip, which has an effect strip applied to it, which is also inside a meta strip. 1. Add a color strip at frame 50 2. Add a glow effect on the color strip 3. Group them inside a meta strip 4. Quickly move the color strip to the right 5. Exit the meta strip and move the meta strip. 6. **The strip "jumps" backward.** ` ` 1. Add a movie strip at frame 50 2. Add a glow effect on the movie strip 3. Group them inside a meta strip 4. Entire retiming mode on the movie strip and quickly move the left retiming key to the right 5. Exit the meta strip and move the meta strip. 6. **The strip "jumps" backward.** This calculation order is also in the code for adding an effect strip. If the effect strip is added on the color strip before grouping, the bug doesn't appear: 1. Add a color strip on frame 50 2. Group it inside a meta strip 3. Go inside the meta strip and add a glow effect on the color strip 4. Exit the meta strip and move the meta strip. 5. **The strip "jumps" to frame 0.** ### Review notes `SEQ_time_update_meta_strip_range(...)` function: - Effect strips which depend on other strips are included in the calculation for the meta strip range. The code could be changed to exclude them. Doing that might obscure other bugs though. - I'm not sure if the calculation order of `SEQ_time_update_meta_strip_range` and `seq_time_update_effects_strip_range` has any impact in this function, but it could be changed along with the other ones in this PR for consistency.

ok what added 1 commit 2023-11-08 21:36:29 +01:00

c86eb8d889 Fix: Incorrect calculation of meta strip range

The meta strip range was calculated before the effect strip
range was updated. To the user this appeared as the meta strip
erratically jumping to another location in the timeline when
transforming it, under specific conditions.

Iliya Katushenock added the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Fix: Incorrect calculation of meta strip range #114644

Ways to reproduce

Review notes