Vulkan: Retarget Depth Range #114669

Merged

Jeroen Bakker merged 4 commits from Jeroen-Bakker/blender:vulkan/retarget-depth-range into main

2023-11-10 12:32:17 +01:00

Jeroen Bakker commented

2023-11-09 14:44:11 +01:00

Member

OpenGL uses a depth range between -1 and 1, which is then normalized.
Metal & Vulkan uses a depth range between 0 and 1, which is already normalized.

The final plan would be to default to a depth range between 0 and 1, but
for now the depth ranges are retargetted so they won't be clipped away.

This solves the next issues for users:

Navigate control will be rendered correctly
Ortographic view clipping artifacts
EEVEE light evaluation

Retargetting happens at the end of the vertex stage or when a geometry
stage is present at the end of the geometry stage. Derivatives using
depth would have a different value compared to OpenGL, but would match
Metal backend. OpenGL performs clipping and generates derivatives based
on the original depth value.

gl_FragCoord and clipping would have some precision differences as clipping
and normalizing are done in a different order but would match Metal.

Geometry shaders should use gpu_EmitVertex to ensure that the retargetting
is done per vertex.

OpenGL uses a depth range between -1 and 1, which is then normalized. Metal & Vulkan uses a depth range between 0 and 1, which is already normalized. The final plan would be to default to a depth range between 0 and 1, but for now the depth ranges are retargetted so they won't be clipped away. This solves the next issues for users: - Navigate control will be rendered correctly - Ortographic view clipping artifacts - EEVEE light evaluation Retargetting happens at the end of the vertex stage or when a geometry stage is present at the end of the geometry stage. Derivatives using depth would have a different value compared to OpenGL, but would match Metal backend. OpenGL performs clipping and generates derivatives based on the original depth value. `gl_FragCoord` and clipping would have some precision differences as clipping and normalizing are done in a different order but would match Metal. Geometry shaders should use `gpu_EmitVertex` to ensure that the retargetting is done per vertex.

Jeroen Bakker added this to the 4.1 milestone 2023-11-09 14:44:11 +01:00

Jeroen Bakker added the

label 2023-11-09 14:44:11 +01:00

Jeroen Bakker self-assigned this 2023-11-09 14:44:11 +01:00

Jeroen Bakker added 1 commit 2023-11-09 14:44:20 +01:00

cbd352064c Vulkan: Retarget Depth Range

OpenGL uses a depth range between -1 and 1, which is then normalized.
Metal & Vulkan uses a depth range between 0 and 1, which is already normalized.

The final plan would be to default to a depth range between 0 and 1, but
for now the depth ranges are retargetted so they won't be clipped away.

This solves the next issues for users:
- Navigate control will be rendered correctly
- Ortographic view clipping artifacts

Jeroen Bakker added 1 commit 2023-11-09 14:46:02 +01:00

db26aa4c46 Revert unneeded change

Jeroen Bakker added this to the EEVEE & Viewport project 2023-11-09 14:48:48 +01:00

Jeroen Bakker requested review from Clément Foucault 2023-11-09 14:48:55 +01:00

Jeroen Bakker added 1 commit 2023-11-09 14:49:00 +01:00

dcc93545af Gramar in code comments

Jeroen Bakker added 1 commit 2023-11-09 17:12:18 +01:00

72586e402e Merge branch 'main' into vulkan/retarget-depth-range

Clément Foucault requested changes 2023-11-09 18:38:39 +01:00

Clément Foucault left a comment

Member

I would like some explanation about the derivation of the final remapping. It needs to be documented somewhere even if its only on the PR description.

I would like some explanation about the derivation of the final remapping. It needs to be documented somewhere even if its only on the PR description.

Jeroen Bakker commented

2023-11-10 07:10:48 +01:00

Author

Member

I updated the description, unsure if these are the details you're referring to.

More details we can add in https://developer.blender.org/docs/eevee_and_viewport/gpu/vulkan/

I updated the description, unsure if these are the details you're referring to. More details we can add in https://developer.blender.org/docs/eevee_and_viewport/gpu/vulkan/

Jeroen Bakker requested review from Clément Foucault 2023-11-10 07:10:58 +01:00

Jeroen Bakker commented

2023-11-10 12:31:47 +01:00

Author

Member

PR was approved IRL

PR was approved IRL

Jeroen Bakker merged commit 0c9433bf44 into main

2023-11-10 12:32:17 +01:00

Jeroen Bakker referenced this issue from a commit

2023-11-10 12:32:18 +01:00

Vulkan: Retarget Depth Range

Clément Foucault approved these changes 2023-11-10 12:42:19 +01:00

Sign in to join this conversation.

No reviewers

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#114669

No description provided.