UI: Change walk gravity settings UI to reflect the actual behavior #114670

Sun Kim · 2023-11-09T14:44:30+01:00

Sun Kim commented

2023-11-09 14:44:30 +01:00

Change the gravity options in the navigation preferences so that they reflect the actual behavior.

The Gravity option there only decides if walk navigation starts with gravity enabled or not, and gravity can be toggled anytime during the navigation (G or Tab key). So the height options are, unlike the impression the current UI gives, always used whether the Gravity option is enabled or not.

Also change the Gravity option's name to Start with Gravity Enabled.

Change the gravity options in the navigation preferences so that they reflect the actual behavior. The Gravity option there only decides if walk navigation starts with gravity enabled or not, and gravity can be toggled anytime during the navigation (`G` or `Tab` key). So the height options are, unlike the impression the current UI gives, always used whether the Gravity option is enabled or not. Also change the Gravity option's name to `Start with Gravity Enabled`. ![gravity_pref_changes.png](/attachments/8b335c79-6cf9-4e85-94ca-92e783eed498)

gravity_pref_changes.png

44 KiB

Sun Kim added 1 commit 2023-11-09 14:44:43 +01:00

80c7b839b8 Change walk gravity settings UI to reflect the actual behavior

Pratik Borhade approved these changes 2023-11-10 10:05:00 +01:00

Pratik Borhade left a comment

Hi, thanks for the PR. This make sense to me. But do we really need use_gravity toggle in user preferences?
cc @pablovazquez

Hi, thanks for the PR. This make sense to me. But do we really need `use_gravity` toggle in user preferences? cc @pablovazquez

👍 1

Sun Kim commented

2023-11-10 10:34:51 +01:00

@PratikPB2123 Hi, thanks for the review!

Personally I don't really care for the option as I always manually activate gravity when it's needed. I think it's a little finicky since you have to make sure that you're at a safe position that won't make you fall infinitely, or immediately disable gravity before the fall, which makes the option meaningless.

One more thing: I think I need to change the tooltips (make it clear that the gravity option only affects start status, state that height options are used when gravity is enabled) as well. If I understand correctly they should be changed in rna_userdef.cc. I wonder, since they are simple string changes, if it's okay to submit the changes without compiling Blender and verify them myself.

@PratikPB2123 Hi, thanks for the review! Personally I don't really care for the option as I always manually activate gravity when it's needed. I think it's a little finicky since you have to make sure that you're at a safe position that won't make you fall infinitely, or immediately disable gravity before the fall, which makes the option meaningless. One more thing: I think I need to change the tooltips (make it clear that the gravity option only affects start status, state that height options are used when gravity is enabled) as well. If I understand correctly they should be changed in `rna_userdef.cc`. I wonder, since they are simple string changes, if it's okay to submit the changes without compiling Blender and verify them myself.

👍 1

Pratik Borhade requested review from Pablo Vazquez 2023-11-10 11:56:56 +01:00

Sun Kim added 1 commit 2023-11-20 12:42:01 +01:00

71012a0c76 Modify tooltips

Sun Kim commented

2023-11-20 12:46:42 +01:00

I went ahead and modified the tooltips.

@pablovazquez Hi, can you take a look at this?

I went ahead and modified the tooltips. @pablovazquez Hi, can you take a look at this?

Merge conflict checking is in progress. Try again in few moments.

View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u pref_ui_gravity:persun-pref_ui_gravity

git checkout persun-pref_ui_gravity

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

UI: Change walk gravity settings UI to reflect the actual behavior #114670

Checkout