Fix #114536: Redo panel too small when opening 4.0 files in 3.6 #114715

Merged
Member

Forward compatibility fix for the 3.6 branch only.

Problem is 4.0 sets the RGN_FLAG_NO_USER_RESIZE in versioning for
a number of regions. When reading 4.0 files this would match the
RGN_FLAG_PREFSIZE_OR_HIDDEN flag, causing wrong region sizes.

I experimented with only clearing the flag for the redo panel, but I
noticed the flag would also mess with the File Browser region showing
the file path when saved in a layout. So clear it for all regions that
don't intentionally use it.

Another option is to not reuse the flag-bit in 4.0. However reusing
flag-bits should be fine, such forward compatibility patches are not a
big deal IMO.

Forward compatibility fix for the 3.6 branch only. Problem is 4.0 sets the RGN_FLAG_NO_USER_RESIZE in versioning for a number of regions. When reading 4.0 files this would match the RGN_FLAG_PREFSIZE_OR_HIDDEN flag, causing wrong region sizes. I experimented with only clearing the flag for the redo panel, but I noticed the flag would also mess with the File Browser region showing the file path when saved in a layout. So clear it for all regions that don't intentionally use it. Another option is to not reuse the flag-bit in 4.0. However reusing flag-bits should be fine, such forward compatibility patches are not a big deal IMO.
Julian Eisel added this to the 3.6 LTS milestone 2023-11-10 16:58:21 +01:00
Julian Eisel added the
Module
User Interface
label 2023-11-10 16:58:21 +01:00
Julian Eisel added 1 commit 2023-11-10 16:58:33 +01:00
1ad469bda0 Fix #114536: Redo panel to small when opening 4.0 files in 3.6
Forward compatibility fix for the 3.6 branch only.

Problem is 4.0 sets the RGN_FLAG_NO_USER_RESIZE in versioning for
a number of regions. When reading 4.0 files this would match the
RGN_FLAG_PREFSIZE_OR_HIDDEN flag, causing wrong region sizes.

I experimented with only clearing the flag for the redo panel, but I
noticed the flag would also mess with the File Browser region showing
the file path when saved in a layout. So clear it for all regions that
don't intentionally use it.

Another option is to not reuse the flag-bit in 4.0. However reusing
flag-bits should be fine, such forward compatibility patches are not a
big deal IMO.
Julian Eisel requested review from Brecht Van Lommel 2023-11-10 16:59:21 +01:00
Brecht Van Lommel approved these changes 2023-11-10 17:13:43 +01:00
Julian Eisel changed title from Fix #114536: Redo panel to small when opening 4.0 files in 3.6 to Fix #114536: Redo panel too small when opening 4.0 files in 3.6 2023-11-10 19:01:30 +01:00
Julian Eisel merged commit e0492754fe into blender-v3.6-release 2023-11-11 23:11:47 +01:00
Julian Eisel deleted branch temp-fix-3.6-redo-panel-forward-compatibility 2023-11-11 23:11:51 +01:00
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#114715
No description provided.