WIP: Node Editor: Improve readability of dashed node links #114716

Draft
Leon Schittek wants to merge 3 commits from lone_noel/blender:nodelink-dash-readability into main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Member

This PR attempts to make nodelinks more readable:

  1. Links are about 25% wider, when zoomed out.
  2. The size of the dashes stays approximately constant in screen space
    to keep the dash pattern readable even on lower zoom levels.

Issue

There is a report about the readability of dashed node links: #102919.
The issue was somewhat improved by 899d723da8 but the dash pattern of field links scaling with the view makes it inevitable that it becomes hard to read at some point.

To help with that this PR makes it so the dash pattern blends between differently scales keeping it from getting too small - similarly to how it's done for the dot grid in the node editor's background.

Comparison

It's best to open the two "overview" screenshots in separate tabs and view them at 100% to really see the difference.
You should notice that with the PR the dash pattern is still readable when being zoomed out.

zoom main pull request
overview nodelinks_main.png nodelinks_pr.png
far main_detail-1.png pr_detail-1.png
medium main_detail-2.png pr_detail-2.png
close main_detail-3.png pr_detail-3.png
This PR attempts to make nodelinks more readable: 1. Links are about 25% wider, when zoomed out. 2. The size of the dashes stays approximately constant in screen space to keep the dash pattern readable even on lower zoom levels. --- ### Issue There is a report about the readability of dashed node links: https://projects.blender.org/blender/blender/issues/102919. The issue was somewhat improved by https://projects.blender.org/blender/blender/commit/899d723da8bbdac4947e0efae531af1f510ed813 but the dash pattern of field links scaling with the view makes it inevitable that it becomes hard to read at some point. To help with that this PR makes it so the dash pattern blends between differently scales keeping it from getting too small - similarly to how it's done for the dot grid in the node editor's background. ### Comparison It's best to open the two "overview" screenshots in separate tabs and view them at 100% to really see the difference. You should notice that with the PR the dash pattern is still readable when being zoomed out. |zoom|main|pull request| |---|---|---| |overview|![nodelinks_main.png](/attachments/2422d02b-d44b-42ed-a6d2-8af47df05f59)|![nodelinks_pr.png](/attachments/2561f8ca-7f80-4eed-ae2c-1192e9537b90)| |far|![main_detail-1.png](/attachments/d2717dfb-070f-4157-a7ac-99364c1397fd)|![pr_detail-1.png](/attachments/b151eb7d-8f3d-48b1-ac51-8dad415a20ba)| |medium|![main_detail-2.png](/attachments/ab5f436a-9fbe-4736-8c57-c7c5636fa31e)|![pr_detail-2.png](/attachments/d283cbb8-c2fe-4a00-a8d2-990b344cca93)| |close|![main_detail-3.png](/attachments/b8b409e8-0100-442f-9458-5db8a61f5ff9)|![pr_detail-3.png](/attachments/a585ec23-9be3-4a77-961c-079bc6058c5c)|
Leon Schittek added 3 commits 2023-11-10 18:19:20 +01:00
This pull request has changes conflicting with the target branch.
  • source/blender/gpu/shaders/gpu_shader_2D_nodelink_frag.glsl

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u nodelink-dash-readability:lone_noel-nodelink-dash-readability
git checkout lone_noel-nodelink-dash-readability
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#114716
No description provided.