Fix #114714: Rotating the View can drastically change the view's position when Auto Depth or Orbit Arround Select is set #114726

Germano Cavalcante · 2023-11-10T23:08:55+01:00

2023-11-10 23:08:55 +01:00

Caused by 6faa39edb7

In that commit it was assumed that the view offset does not need to be
updated if the operator is V3D_OP_MODE_ROTATE instead of simply
checking this->use_dyn_ofs.

Since use_dyn_ofs is always True when using Auto Depth or Orbit
Arround Select, the offset should always be updated in these cases.

Caused by 6faa39edb7 In that commit it was assumed that the view offset does not need to be updated if the operator is `V3D_OP_MODE_ROTATE` instead of simply checking `this->use_dyn_ofs`. Since `use_dyn_ofs` is always `True` when using Auto Depth or Orbit Arround Select, the offset should always be updated in these cases.

Germano Cavalcante added 1 commit 2023-11-10 23:09:06 +01:00

Fix #114714 : Rotating the View can drastically change the view's position when Auto Depth or Orbit Arround Select is set

buildbot/vdev-code-daily-coordinator Build done.

Details

172221e7fb

Caused by 6faa39edb7

In that commit it was assumed that the view offset does not need to be
updated if the operator is `V3D_OP_MODE_ROTATE` instead of simply
checking `this->use_dyn_ofs`.

Since `use_dyn_ofs` is always `True` when using Auto Depth or Orbit
Arround Select, the offset should always be updated in these cases.

Germano Cavalcante commented

2023-11-10 23:13:24 +01:00

@ThomasDinges, regression fixed in main (172221e7fb)

Is there still time for 4.0?

@ThomasDinges, regression fixed in main (172221e7fb892f7cbf7a8c58a44351c5a48321e1) Is there still time for 4.0?

Germano Cavalcante force-pushed fix_114714 from 172221e7fb to 1022f2324e

2023-11-10 23:14:52 +01:00

Compare

Germano Cavalcante requested review from Thomas Dinges 2023-11-10 23:15:12 +01:00

Germano Cavalcante changed title from ~~Fix #114714: Rotating the View can drastically change the view's position when Auto Depth or Orbit Arround Select is set~~ to Fix #114714: Rotating the View can drastically change the view's position when Auto Depth or Orbit Arround Select is set

2023-11-10 23:15:27 +01:00

Germano Cavalcante changed target branch from main to blender-v4.0-release

2023-11-10 23:15:29 +01:00

Germano Cavalcante merged commit b98bc26173 into blender-v4.0-release

2023-11-13 14:30:22 +01:00

Germano Cavalcante referenced this issue from a commit

2023-11-13 14:30:22 +01:00

Fix #114714: Rotating the View can drastically change the view's position when Auto Depth or Orbit Arround Select is set

Germano Cavalcante deleted branch fix_114714

2023-11-13 14:30:28 +01:00

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Fix #114714: Rotating the View can drastically change the view's position when Auto Depth or Orbit Arround Select is set #114726