WIP: Experiment with solvespace library #114757

Jacques Lucke · 2023-11-12T13:01:29+01:00

Jacques Lucke commented

2023-11-12 13:01:29 +01:00

Playing with the CAD Sketcher addon made me want to play with the solvespace library. I don't have any concrete plan to continue to work on this myself, just wanted to get a better understand for how it works for now.

The image shows how the library solves a distance constraint between the two vertices.

Testing this currently requires some manual effort to get the library to link. I had to apply the changes below to solvespace so that it results in a static library without additional dependencies.

Solvespace Patch

diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
index 0e9129f..b3c5aa3 100644
--- a/src/CMakeLists.txt
+++ b/src/CMakeLists.txt
@@ -66,7 +66,7 @@ if(APPLE)
 endif()
 
 # libslvs
-add_library(slvs SHARED
+add_library(slvs STATIC
     solvespace.h
     platform/platform.h
     util.cpp
diff --git a/src/platform/platform.cpp b/src/platform/platform.cpp
index 6ad19dc..fa29466 100644
--- a/src/platform/platform.cpp
+++ b/src/platform/platform.cpp
@@ -698,22 +698,21 @@ void DebugPrint(const char *fmt, ...) {
 //-----------------------------------------------------------------------------
 
 struct MimallocHeap {
+    std::vector<void *> buffers;
     mi_heap_t *heap = NULL;
 
     ~MimallocHeap() {
-        if(heap != NULL)
-            mi_heap_destroy(heap);
+        for (void *buffer : buffers) {
+            free(buffer);
+        }
     }
 };
 
 static thread_local MimallocHeap TempArena;
 
 void *AllocTemporary(size_t size) {
-    if(TempArena.heap == NULL) {
-        TempArena.heap = mi_heap_new();
-        ssassert(TempArena.heap != NULL, "out of memory");
-    }
-    void *ptr = mi_heap_zalloc(TempArena.heap, size);
+    void *ptr = malloc(size);
+    TempArena.buffers.push_back(ptr);
     ssassert(ptr != NULL, "out of memory");
     return ptr;
 }

Playing with the [CAD Sketcher](https://www.cadsketcher.com/) addon made me want to play with the [solvespace](https://github.com/solvespace/solvespace) library. I don't have any concrete plan to continue to work on this myself, just wanted to get a better understand for how it works for now. The image shows how the library solves a distance constraint between the two vertices. ![image](/attachments/be93dfa5-f9a4-43bc-b5c7-974b54b382d2) Testing this currently requires some manual effort to get the library to link. I had to apply the changes below to [solvespace](https://github.com/solvespace/solvespace) so that it results in a static library without additional dependencies. <details> <summary>Solvespace Patch</summary> ```diff diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt index 0e9129f..b3c5aa3 100644 --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt @@ -66,7 +66,7 @@ if(APPLE) endif() # libslvs -add_library(slvs SHARED +add_library(slvs STATIC solvespace.h platform/platform.h util.cpp diff --git a/src/platform/platform.cpp b/src/platform/platform.cpp index 6ad19dc..fa29466 100644 --- a/src/platform/platform.cpp +++ b/src/platform/platform.cpp @@ -698,22 +698,21 @@ void DebugPrint(const char *fmt, ...) { //----------------------------------------------------------------------------- struct MimallocHeap { + std::vector<void *> buffers; mi_heap_t *heap = NULL; ~MimallocHeap() { - if(heap != NULL) - mi_heap_destroy(heap); + for (void *buffer : buffers) { + free(buffer); + } } }; static thread_local MimallocHeap TempArena; void *AllocTemporary(size_t size) { - if(TempArena.heap == NULL) { - TempArena.heap = mi_heap_new(); - ssassert(TempArena.heap != NULL, "out of memory"); - } - void *ptr = mi_heap_zalloc(TempArena.heap, size); + void *ptr = malloc(size); + TempArena.buffers.push_back(ptr); ssassert(ptr != NULL, "out of memory"); return ptr; } ``` </details>

image.png

118 KiB

❤️ 3

Jacques Lucke added 1 commit 2023-11-12 13:01:43 +01:00

d31e4e5f01 initial test

Iliya Katushenock commented

2023-11-12 13:15:12 +01:00

I have no any experience with any CAD (just few know about its workflow and seen video series about developing simple CAD on C#). Is that contastaits is something like system to solve to compute final transform? I hope that could be builded from a field. Just not sure if solvespace workflow is similar to geometry nodes one. Wondering you already have thought about that?

Jacques Lucke commented

2023-11-12 13:18:48 +01:00

I don't think the solving would be integrated into geometry nodes (at least at the beginning). I'm just putting my experiments into nodes because that's the area I know best. The solving is more likely to be done on original geometry, similar to what the CAD Sketcher addon does, maybe just give it a try.

This pull request has changes conflicting with the target branch.

source/blender/nodes/geometry/CMakeLists.txt

View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u slvs-test:JacquesLucke-slvs-test

git checkout JacquesLucke-slvs-test

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

WIP: Experiment with solvespace library #114757

Checkout