IO: C++ STL exporter #114862
No reviewers
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#114862
Loading…
Reference in New Issue
No description provided.
Delete Branch "aras_p/blender:io-cpp-stl-exporter"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
There was a C++ STL importer since Blender 3.3, but no corresponding C++ STL exporter. This PR is adding said exporter: taking #105598 and finishing it (agreed with original author).
Exporting Suzanne with 6 level subdivision (4 million triangles), on M1 Max:
@blender-bot build
WIP: IO: C++ STL exporter, continuedto IO: C++ STL exporterThis seems pretty straightforward. It's a nice short exporter!
To me the virtual file writer class doesn't seem necessary though. The behavior is only switched in two places-- when initially creating the file, and inside of the hot loop. For the former, just one extra check seems fine, and getting rid of the virtual function call in the hot loop seems nicer anyway (writing multiple triangles in batches might help too? but fine to leave some performance on the table for now-- the virtual class comment is more about avoiding unnecessary code complexity).
@ -27,0 +93,4 @@
sub, op_props_ptr, "apply_modifiers", UI_ITEM_NONE, IFACE_("Apply Modifiers"), ICON_NONE);
}
static void wm_stl_export_draw([[maybe_unused]] bContext *C, wmOperator *op)
Our standard way of marking unused arguments is
/*C*/
in C++ code.[[maybe_unused]]
is more designed for templates andif constexpr
code where whether something is used depends on some metaprogramming or something.@ -27,0 +116,4 @@
return changed;
}
void WM_OT_stl_export(struct wmOperatorType *ot)
Unnecessary
struct
in C++Indeed, just folded them both into one simple writer class. No virtuals, and fewer lines of code too.
It should be easy to write multiple triangles at once indeed, but I'd rather do that sometime later.
@blender-bot build
Looks good. The export does feel noticeably way faster than the Python version. And nice that there's still room for improvement :D
Not sure the
FileWriter
class is necessary at all TBH, but I guess it's a common abstraction among other exporters, and it doesn't matter so much.@ -0,0 +48,4 @@
* triangles have been written). */
fwrite(&tris_num_, sizeof(uint32_t), 1, file_);
}
}
Usually there are newlines between functions.