Nodes: improve socket picking tolerances #115010

Jacques Lucke · 2023-11-16T19:44:22+01:00

Jacques Lucke commented

2023-11-16 19:44:22 +01:00

The goal here is to make it easier to make node links. Previously, it was quite easy to accidentally start box selection or to trigger the link-drag-search when that was not intended.

Now, the tolerances are a bit easier to work with. Also, instead of trying to use the first socket that is close enough, it will find the closest socket instead. It feels much better in my testing already, but obviously the values can be tuned more with some testing.

Also we have to make sure to not accidentally make other things like resizing nodes harder.

The goal here is to make it easier to make node links. Previously, it was quite easy to accidentally start box selection or to trigger the link-drag-search when that was not intended. Now, the tolerances are a bit easier to work with. Also, instead of trying to use the first socket that is close enough, it will find the closest socket instead. It feels much better in my testing already, but obviously the values can be tuned more with some testing. Also we have to make sure to not accidentally make other things like resizing nodes harder.

👍 3 🎉 1

Jacques Lucke added 1 commit 2023-11-16 19:44:35 +01:00

68b6faa5f5 improve socket picking

Jacques Lucke requested review from Lukas Tönne 2023-11-16 19:45:32 +01:00

Jacques Lucke requested review from Simon Thommes 2023-11-16 19:45:32 +01:00

Jacques Lucke requested review from Hans Goudey 2023-11-16 19:45:32 +01:00

Lukas Tönne approved these changes 2023-11-17 15:14:51 +01:00

Lukas Tönne left a comment

Code looks good, and i didn't find any issues during testing.

Simon Thommes approved these changes 2023-11-24 16:28:22 +01:00

Simon Thommes left a comment

Feels much better!

I don't see any issues with this. If anything the radius could be increased even more. But this is probably a good balance. Definitely much closer to the optimum than it was.

Feels much better! I don't see any issues with this. If anything the radius could be increased even more. But this is probably a good balance. Definitely much closer to the optimum than it was.

Jacques Lucke merged commit 74dd1e044b into main

2023-11-25 15:23:41 +01:00

Jacques Lucke referenced this issue from a commit

2023-11-25 15:23:43 +01:00

Nodes: improve socket picking tolerances

Jacques Lucke deleted branch socket-picking

2023-11-25 15:23:43 +01:00

Hans Goudey referenced this issue from a commit

2023-11-27 18:01:11 +01:00

Nodes: improve socket picking tolerances

Som1Lse referenced this issue from a commit

2023-11-27 18:49:10 +01:00

Nodes: improve socket picking tolerances

AgentA1cr commented

2023-11-27 19:09:18 +01:00

First-time contributor

The improvement is definitely welcome overall, but the radius that a socket can be grabbed from in the latest daily build seems a little too large, and makes it difficult to resize some nodes because it takes up most of the side.