Manpage: python script byte to string to fix blender.1.py #115127

HurricanePootis · 2023-11-19T10:57:14+01:00

HurricanePootis commented

2023-11-19 10:57:14 +01:00

Problem

As of right now, the blender.1.py script used to create the man page does not work. Whenever run with the following command (as per instructed in the header of the script), the error listed below the command is returned.

hurricane@TheCloutPC /run/media/hurricane/newmaindata/mine/blender/build/bin $ ./blender -b --python /run/media/hurricane/newmaindata/mine/blender/doc/manpage/blender.1.py -- --output blender.1
Blender 4.0.1 (hash d0dd92834a08 built 2023-11-19 08:46:17)
Read prefs: "/home/hurricane/.config/blender/4.0/config/userpref.blend"
Error: Python: Traceback (most recent call last):
  File "/run/media/hurricane/newmaindata/mine/blender/doc/manpage/blender.1.py", line 167, in main
    man_page_from_blender_help(fh, verbose)
  File "/run/media/hurricane/newmaindata/mine/blender/doc/manpage/blender.1.py", line 54, in man_page_from_blender_help
    blender_info = blender_extract_info()
                   ^^^^^^^^^^^^^^^^^^^^^^
  File "/run/media/hurricane/newmaindata/mine/blender/doc/manpage/blender.1.py", line 44, in blender_extract_info
    blender_date = time.strftime("%B %d, %Y", time.strptime(blender_build_date_text, "%Y-%m-%d"))
                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/_strptime.py", line 562, in _strptime_time
    tt = _strptime(data_string, format)[0]
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/_strptime.py", line 317, in _strptime
    raise TypeError(msg.format(index, type(arg)))
TypeError: strptime() argument 0 must be str, not <class 'bytes'>

Blender quit

The fix

I added a .decode() to the end of blender_build_date_text to create blender_build_date_text.decode(). This converts the object bytes into a string, which time.strptime() can accept.

The whole reason I am doing this fix because, to my knowledge, the Arch Linux blender package maintainer hasn't yet released blender 4 on Arch because the man page was not being generated. Therefore, I decided to dig into this problem using my own experience. Eventually, after many lengthy compiles, I tracked down the issue to the python script.

My System & Notice

Arch Linux
Python 3.11.5
Glibc 2.38
Radeon RX 6800
Ryzen 5 5600X

I am not a developer, and this was my first time working with python. I apologize if I do anything wrong in creating this pull request, and I look forward to learning how to better myself in this professional environment.

# Problem As of right now, the `blender.1.py` script used to create the man page does not work. Whenever run with the following command (as per instructed in the header of the script), the error listed below the command is returned. ```python hurricane@TheCloutPC /run/media/hurricane/newmaindata/mine/blender/build/bin $ ./blender -b --python /run/media/hurricane/newmaindata/mine/blender/doc/manpage/blender.1.py -- --output blender.1 Blender 4.0.1 (hash d0dd92834a08 built 2023-11-19 08:46:17) Read prefs: "/home/hurricane/.config/blender/4.0/config/userpref.blend" Error: Python: Traceback (most recent call last): File "/run/media/hurricane/newmaindata/mine/blender/doc/manpage/blender.1.py", line 167, in main man_page_from_blender_help(fh, verbose) File "/run/media/hurricane/newmaindata/mine/blender/doc/manpage/blender.1.py", line 54, in man_page_from_blender_help blender_info = blender_extract_info() ^^^^^^^^^^^^^^^^^^^^^^ File "/run/media/hurricane/newmaindata/mine/blender/doc/manpage/blender.1.py", line 44, in blender_extract_info blender_date = time.strftime("%B %d, %Y", time.strptime(blender_build_date_text, "%Y-%m-%d")) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/lib/python3.11/_strptime.py", line 562, in _strptime_time tt = _strptime(data_string, format)[0] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/lib/python3.11/_strptime.py", line 317, in _strptime raise TypeError(msg.format(index, type(arg))) TypeError: strptime() argument 0 must be str, not <class 'bytes'> Blender quit ``` # The fix I added a `.decode()` to the end of `blender_build_date_text` to create `blender_build_date_text.decode()`. This converts the object bytes into a string, which time.strptime() can accept. The whole reason I am doing this fix because, to my knowledge, the Arch Linux blender package maintainer hasn't yet released blender 4 on Arch because the man page was not being generated. Therefore, I decided to dig into this problem using my own experience. Eventually, after many lengthy compiles, I tracked down the issue to the python script. # My System & Notice Arch Linux Python 3.11.5 Glibc 2.38 Radeon RX 6800 Ryzen 5 5600X I am not a developer, and this was my first time working with python. I apologize if I do anything wrong in creating this pull request, and I look forward to learning how to better myself in this professional environment.

HurricanePootis added 1 commit 2023-11-19 10:57:30 +01:00

599e2cc1f6 Manpage python script byte to string

HurricanePootis changed title from ~~Manpage python script byte to string~~ to Manpage: python script byte to string to fix blender.1.py

2023-11-19 11:15:41 +01:00

Sven-Hendrik Haase referenced this pull request

2023-11-19 19:47:55 +01:00

Regression: cmake install error for man page #115056

Brecht Van Lommel approved these changes 2023-11-22 20:00:04 +01:00

Brecht Van Lommel merged commit 70e2c0bcd4 into main

2023-11-22 20:01:07 +01:00

Brecht Van Lommel referenced this issue from a commit

2023-11-22 20:01:07 +01:00

Fix #115056: man page generation fails with Python error

Brecht Van Lommel referenced this issue from a commit

2023-11-22 20:02:00 +01:00

Fix "make doc_man" not working, after changes in 61d99d45

Brecht Van Lommel referenced this issue from a commit

2023-11-22 20:03:01 +01:00

Fix #115056: man page generation fails with Python error

Brecht Van Lommel referenced this issue from a commit

2023-11-22 20:03:01 +01:00

Fix "make doc_man" not working, after changes in 61d99d45

Brecht Van Lommel commented

2023-11-22 20:03:16 +01:00

This has been backported to the 4.0 branch as well.

Sven-Hendrik Haase commented

2023-11-23 05:11:46 +01:00

First-time contributor

Blender Arch maintainer here. This patch doesn't fix the problem for me. The author of this patch has produced a different solution for Arch Linux. However, I'd prefer if the actual problem could be fixed upstream.

Brecht Van Lommel commented

2023-11-23 22:11:23 +01:00

Additional fix in #115320.

Som1Lse referenced this issue from a commit

2023-11-27 18:49:09 +01:00

Fix #115056: man page generation fails with Python error

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Manpage: python script byte to string to fix blender.1.py #115127

Problem

The fix

My System & Notice