Text Editor: Use active text selection as search query #115247

Guillermo Venegas · 2023-11-21T20:31:17+01:00

Guillermo Venegas commented

2023-11-21 20:31:17 +01:00

Now when using the shortcut/operator to begin search in the
text editor the active text selection is used as search query.

Also previously while using the operator to begin search, the input
field that contains the query was activated, but it was not
properly highlighted as active, now using the shortcut shows
correctly the input field as active.

The text selection is used as search query only if the mouse is
over the main region of the text space and if the selection is in
just one line.

Now when using the shortcut/operator to begin search in the text editor the active text selection is used as search query. Also previously while using the operator to begin search, the input field that contains the query was activated, but it was not properly highlighted as active, now using the shortcut shows correctly the input field as active. The text selection is used as search query only if the mouse is over the main region of the text space and if the selection is in just one line.

❤️ 4

Guillermo Venegas added 1 commit 2023-11-21 20:31:28 +01:00

689f95a90c init

Guillermo Venegas requested review from Pablo Vazquez 2023-11-21 20:33:07 +01:00

Guillermo Venegas requested review from Harley Acheson 2023-11-21 20:33:07 +01:00

Guillermo Venegas commented

2023-11-21 21:50:28 +01:00

2023-11-21 14-46-50.mp4

6.5 MiB

Guillermo Venegas commented

2023-11-21 22:10:31 +01:00

find_set_selected, does the same thing in some way, but that operator copies the selected text and looks for the next location

Personally, I am more used to pressing ctrl + f and having a search window open with the text I have selected and search the next or previous one

`find_set_selected`, does the same thing in some way, but that operator copies the selected text and looks for the next location Personally, I am more used to pressing `ctrl + f` and having a search window open with the text I have selected and search the next or previous one

Guillermo Venegas referenced this pull request

2023-11-26 00:59:17 +01:00

Text Editor: Find & Replace improvements #115428

Harley Acheson commented

2023-11-29 20:31:57 +01:00

Hey, that works really well. I especially like how it properly activates the Find box with text cursor too.

I like that it only puts the selected text into the Find box for single-line selections. This means we could potentially still an option later to search within the selected text only (assuming it is multiline). But this should probably be in a comment, like alter your existing comment to something like "Use active text selection as a search query, if single line" or similar.

There is only one part that feels a bit off, but could be intentional. If I have searched for something earlier, but now the sidebar is closed. I select multiple lines of text, then press Ctrl-F. The sidebar pops out nicely, the Find box is activated, but the last search string is in there. Is the last search string useful in this case or should the search text just be blank?

Hey, that works really well. I especially like how it properly activates the Find box with text cursor too. I like that it only puts the selected text into the Find box for single-line selections. This means we could potentially still an option later to search within the selected text only (assuming it is multiline). But this should probably be in a comment, like alter your existing comment to something like "Use active text selection as a search query, if single line" or similar. There is only one part that feels a bit off, but could be intentional. If I have searched for something earlier, but now the sidebar is closed. I select multiple lines of text, then press Ctrl-F. The sidebar pops out nicely, the Find box is activated, but the last search string is in there. Is the last search string useful in this case or should the search text just be blank?

Guillermo Venegas commented

2023-11-29 23:33:28 +01:00

Is the last search string useful in this case or should the search text just be blank

It also happens without selection, but I don't have a strong opinion about it.
I feel that it can be useful to be able to continue searching what we were already looking for, change the search string only if selection is in a single line.

With search highlight feels better (#115417)

> Is the last search string useful in this case or should the search text just be blank It also happens without selection, but I don't have a strong opinion about it. I feel that it can be useful to be able to continue searching what we were already looking for, change the search string only if selection is in a single line. With search highlight feels better (https://projects.blender.org/blender/blender/pulls/115417) <video src="/attachments/8f371203-8fd0-434f-8989-6064d393e118" title="2023-11-29 16-23-49.mp4" controls></video>

2023-11-29 16-23-49.mp4

1017 KiB

Harley Acheson commented

2023-11-30 01:51:54 +01:00

It also happens without selection, but I don't have a strong opinion about it.

Yes, I'm not sure either. I guess what I worry about is the differing result if you select a portion of a line and press Ctrl-F versus selecting a portion that spans two lines. Having it blank in the latter keeps from not noticing.

With search highlight feels better (#115417)

Oh that is nice! You have to finish that baby. I can imagine it being a bit different with syntax highlighting on.

> It also happens without selection, but I don't have a strong opinion about it. Yes, I'm not sure either. I guess what I worry about is the differing result if you select a portion of a line and press Ctrl-F versus selecting a portion that spans two lines. Having it blank in the latter keeps from not noticing. > With search highlight feels better (https://projects.blender.org/blender/blender/pulls/115417) Oh that is nice! You have to finish that baby. I can imagine it being a bit different with syntax highlighting on.

Guillermo Venegas added 2 commits 2023-11-30 16:12:08 +01:00

88dd643ffe Merge remote-tracking branch 'origin/main' into quick-search

buildbot/vexp-code-patch-coordinator Build done. Details

87df53e715 improve comments, fix and cleanup unused var

Harley Acheson commented

2023-11-30 17:06:01 +01:00

@blender-bot build

Harley Acheson commented

2023-11-30 17:58:09 +01:00

I guess I also don't have a strong opinion on that. I think we should just put this in as an obvious solution and we can adjust that behavior later if need be.

Harley Acheson approved these changes 2023-11-30 18:23:54 +01:00

Harley Acheson left a comment

Love it.

👍 1

Harley Acheson added 1 commit 2023-11-30 18:24:36 +01:00

66afdd0cb6 Merge branch 'main' into quick-search

Harley Acheson merged commit cf08b088ba into main

2023-11-30 18:27:02 +01:00

Harley Acheson referenced this issue from a commit

2023-11-30 18:27:04 +01:00

Text Editor: Use active text selection as search query

Guillermo Venegas deleted branch quick-search

2023-11-30 19:57:39 +01:00

Guillermo Venegas commented

2023-11-30 20:05:11 +01:00

I've been testing and I think it may be a matter of preference.
By the way, is find_set_selected is still useful?
This operator allows to put multi line text in find_text, the search only allow matches in single lines

I've been testing and I think it may be a matter of preference. By the way, is `find_set_selected` is still useful? This operator allows to put multi line text in `find_text`, the search only allow matches in single lines

Campbell Barton referenced this issue from a commit

2023-12-01 01:08:29 +01:00

Fix missing null check from !115247 & simplify

Guillermo Venegas referenced this pull request

2023-12-20 19:52:21 +01:00

Fix unreported: Partial revert changes from #115247 #116392

Sign in to join this conversation.

No reviewers