EEVEE-Next: Disable distant light if world contains absorption #115284

Merged
Clément Foucault merged 5 commits from fclem/blender:eevee-next-world-volume-absorption into main 2023-11-24 13:51:17 +01:00

This restrict the usage of distant light if the world shader
contains absorption phenomenon.

Why this is needed is described in #114062.

At the same time, this removes the parameter for enabling
volume light as this is now an auto-detected optimization.

This also contains a few small cleanups.

This restrict the usage of distant light if the world shader contains absorption phenomenon. Why this is needed is described in #114062. At the same time, this removes the parameter for enabling volume light as this is now an auto-detected optimization. This also contains a few small cleanups.
Clément Foucault added this to the 4.1 milestone 2023-11-22 21:22:55 +01:00
Clément Foucault added the
Interest
EEVEE
Module
EEVEE & Viewport
labels 2023-11-22 21:22:56 +01:00
Clément Foucault added 1 commit 2023-11-22 21:23:11 +01:00
2076e1819d EEVEE-Next: Disable distant light if world contains absorption
This restrict the usage of distant light if the world shader
contains absorption phenomenon.

Why this is needed is described in #114062.

At the same time, this removes the parameter for enabling
volume light as this is now an auto-detected optimization.

This also contains a few small cleanups.
Clément Foucault changed title from EEVEE-Next: Disable distant light if world contains absorption to WIP: EEVEE-Next: Disable distant light if world contains absorption 2023-11-22 21:23:19 +01:00
Clément Foucault added 1 commit 2023-11-23 18:18:18 +01:00
Clément Foucault added 1 commit 2023-11-23 19:13:02 +01:00
Clément Foucault added 1 commit 2023-11-23 19:13:35 +01:00
Author
Member

@blender-bot build

@blender-bot build
Clément Foucault changed title from WIP: EEVEE-Next: Disable distant light if world contains absorption to EEVEE-Next: Disable distant light if world contains absorption 2023-11-23 20:43:18 +01:00
Clément Foucault requested review from Jeroen Bakker 2023-11-23 23:45:42 +01:00
Member

Yes wanderer looks different, but the results are close to Cycles which (IMO) is a good thing.

image
image

I can imagine that users will reporting issues as files look different.

Yes wanderer looks different, but the results are close to Cycles which (IMO) is a good thing. ![image](/attachments/26b8bb7a-765f-411e-a6b4-3a21621520a2) ![image](/attachments/3d484c35-eb43-454d-aa04-ffab08375345) I can imagine that users will reporting issues as files look different.
1.8 MiB
2.5 MiB
Jeroen Bakker approved these changes 2023-11-24 13:00:12 +01:00
Jeroen Bakker left a comment
Member

Yes we should update the demo files, but it depends.
wanderer we might want to remove the world volume shader
in temple I don't know as it overall changes the look.

Other option would be to create cube and add move the volume part to there...

Yes we should update the demo files, but it depends. wanderer we might want to remove the world volume shader in temple I don't know as it overall changes the look. Other option would be to create cube and add move the volume part to there...
@ -121,2 +121,3 @@
/** If false, will prevent all scene light from being synced. */
/** If false, will prevent all scene lights from being synced. */
bool use_scene_lights_ = false;
/** If false, will prevent all sun lights from being synced. */
Member

remove from same to previous comment

remove `from` same to previous comment
Clément Foucault added 1 commit 2023-11-24 13:41:08 +01:00
Clément Foucault merged commit ab7505c7ce into main 2023-11-24 13:51:17 +01:00
Clément Foucault deleted branch eevee-next-world-volume-absorption 2023-11-24 13:51:19 +01:00
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#115284
No description provided.