GPU: cleanup texture view usage flags #115300

Merged
Clément Foucault merged 2 commits from Jason-Fielder/blender:CleanupTextureViewFlags_115269 into main 2023-11-24 15:21:11 +01:00
Member

Texture usage flag GPU_TEXTURE_USAGE_MIP_SWIZZLE_VIEW
was originally implemented and used too conservatively for many
cases in which the underlying API flags were not required.

Renaming to GPU_TEXTURE_USAGE_FORMAT_VIEW to reflect
the only essential use case for when a texture view is initialized with
a different texture format to the source texture. Texture views can
still be created without this flag when mip range or base level is
adjusted,

This flag is still required by stencil views and internally by the Metal
backend for certain feature support such as SRGB render toggling.

Patch also includes some small changes to the Metal backend to
adapt to this new compatibility and correctly capture all texture view
use-cases.

Related to #115269

Authored by Apple: Michael Parkin-White

Texture usage flag `GPU_TEXTURE_USAGE_MIP_SWIZZLE_VIEW` was originally implemented and used too conservatively for many cases in which the underlying API flags were not required. Renaming to `GPU_TEXTURE_USAGE_FORMAT_VIEW` to reflect the only essential use case for when a texture view is initialized with a different texture format to the source texture. Texture views can still be created without this flag when mip range or base level is adjusted, This flag is still required by stencil views and internally by the Metal backend for certain feature support such as SRGB render toggling. Patch also includes some small changes to the Metal backend to adapt to this new compatibility and correctly capture all texture view use-cases. Related to #115269 Authored by Apple: Michael Parkin-White
Jason Fielder added 1 commit 2023-11-23 13:18:49 +01:00
buildbot/vexp-code-patch-coordinator Build done. Details
9458ad9971
Cleanup #115269: GPU: texture view usage flags
Texture usage flag `GPU_TEXTURE_USAGE_MIP_SWIZZLE_VIEW`
was originally implemented and used too conservatively for many
cases in which the underlying API flags were not required.

Renaming to `GPU_TEXTURE_USAGE_FORMAT_VIEW` to reflect
the only essential use case for when a texture view is initialized with
a different texture format to the source texture. Texture views can
still be created without this flag when mip range or base level is
adjusted,

This flag is still required by stencil views and internally by the Metal
backend for certain feature support such as SRGB render toggling.

Patch also includes some small changes to the Metal backend to
adapt to this new compatibility and correctly capture all texture view
use-cases.

Authored by Apple: Michael Parkin-White
Jason Fielder requested review from Clément Foucault 2023-11-23 13:18:54 +01:00
Jason Fielder requested review from Jeroen Bakker 2023-11-23 13:18:59 +01:00
Clément Foucault changed title from Cleanup #115269: GPU: texture view usage flags to GPU: cleanup texture view usage flags 2023-11-23 14:37:13 +01:00
Clément Foucault approved these changes 2023-11-23 19:37:35 +01:00
@ -472,3 +472,1 @@
BLI_assert_msg(
GPU_texture_usage(src) & GPU_TEXTURE_USAGE_MIP_SWIZZLE_VIEW,
"Source texture of TextureView must have GPU_TEXTURE_USAGE_MIP_SWIZZLE_VIEW usage flag.");
BLI_assert_msg((format == GPU_texture_format(src)) ||

Also add assert for stencil texturing.

Also add assert for stencil texturing.

@blender-bot build

@blender-bot build
Clément Foucault added 1 commit 2023-11-24 15:16:23 +01:00
Clément Foucault merged commit 18f7d158fe into main 2023-11-24 15:21:11 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#115300
No description provided.