Color management: multi-thread IMB_colormanagement_transform_from_byte_threaded simple case #115628

Merged
Aras Pranckevicius merged 1 commits from aras_p/blender:cm-transform_from_byte-opt into main 2023-12-01 16:18:57 +01:00

This function is only used in Sequencer code to convert source byte images into float images. For a "simple case" where there is no color space conversion needed, it was doing that on a single thread, in two passes over the image (first byte -> float conversion, then alpha premultiply).

Originally this simple code path was added in combination of ce629c5dd9 and 06ac6ded66 (in 2017).

VSE 4K resolution playback, with two image strips where one of them has "convert to float" option, on Windows / Ryzen 5950X:

  • Overall playback FPS: 3.40 -> 4.03. Still very slow, and a lot of time is spent in allocating, clearing and deleting various temp images, as well as final color conversion for display.
  • seq_imbuf_to_sequencer_space part: 217.9ms -> 86.6ms. Most of remaining cost is just in just memory allocation+clear, which is why it's not drastically faster due to threading.
This function is only used in Sequencer code to convert source byte images into float images. For a "simple case" where there is no color space conversion needed, it was doing that on a single thread, in two passes over the image (first byte -> float conversion, then alpha premultiply). Originally this simple code path was added in combination of ce629c5dd9 and 06ac6ded66 (in 2017). VSE 4K resolution playback, with two image strips where one of them has "convert to float" option, on Windows / Ryzen 5950X: - Overall playback FPS: 3.40 -> 4.03. Still very slow, and a lot of time is spent in allocating, clearing and deleting various temp images, as well as final color conversion for display. - `seq_imbuf_to_sequencer_space` part: 217.9ms -> 86.6ms. Most of remaining cost is just in just memory allocation+clear, which is why it's not drastically faster due to threading.
Aras Pranckevicius added 1 commit 2023-11-30 20:27:47 +01:00
Color management: multi-thread IMB_colormanagement_transform_from_byte_threaded simple case
All checks were successful
buildbot/vexp-code-patch-coordinator Build done.
521fce4b83
This function is only used in Sequencer code to convert source byte
images into float images. For a "simple case" where there is no color
space conversion needed, it was doing that on a single thread, in two
passes over the image (first byte -> float conversion, then alpha
premultiply).

Originally this simple code path was added in combination of ce629c5dd9
and 06ac6ded66 (in 2017).

VSE 4K resolution playback, with two image strips where one of them
has "convert to float" option, on Windows / Ryzen 5950X:
- Overall playback FPS: 3.40 -> 4.03. Still very slow, and a lot of time
  is spent in allocating, clearing and deleting various temp
  images, as well as final color conversion for display.
- seq_imbuf_to_sequencer_space part: 217.9ms -> 86.6ms. Most of remaining
  cost is just in just memory allocation+clear, which is why it's not
  drastically faster due to threading.
Author
Member

@blender-bot build

@blender-bot build
Aras Pranckevicius added this to the Video Sequencer project 2023-11-30 20:28:45 +01:00
Aras Pranckevicius requested review from Sergey Sharybin 2023-12-01 05:59:47 +01:00
Sergey Sharybin approved these changes 2023-12-01 15:29:16 +01:00
Aras Pranckevicius merged commit f3ce0645e4 into main 2023-12-01 16:18:57 +01:00
Aras Pranckevicius deleted branch cm-transform_from_byte-opt 2023-12-01 16:19:00 +01:00
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Code Documentation
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#115628
No description provided.