GHOST/Wayland: use cursor-shape-v1 when available #115701

Campbell Barton · 2023-12-02T10:44:10+01:00

Campbell Barton commented

2023-12-02 10:44:10 +01:00

Using the cursor-shape API avoids having to use low level theme &
cursor buffer access for setting common cursor presets.
This resolves 2 issues.

User defined cursor theme & size being ignored
since Blender accessed the theme directly.
Animated cursors not working as Blender only accessed the
first buffer in the animation.

Using the cursor-shape API avoids having to use low level theme & cursor buffer access for setting common cursor presets. This resolves 2 issues. - User defined cursor theme & size being ignored since Blender accessed the theme directly. - Animated cursors not working as Blender only accessed the first buffer in the animation.

Campbell Barton added 1 commit 2023-12-02 10:44:19 +01:00

3a26822fe8 GHOST/Wayland: use cursor-shape-v1 when available

Using the cursor-shape API avoids having to use low level theme &
cursor buffer access for setting common cursor presets.
This resolves 2 issues.

- User defined cursor theme & size being ignored
  since Blender accessed the theme directly.
- Animated cursors not working as Blender only accessed the
  first buffer in the animation.

Campbell Barton commented

2023-12-02 10:47:25 +01:00

Created for reference but closing as properly managing buffer-cursors, shape-cursors & cursors-in-software is becoming unreasonably complicated.

Ideally this would be able to replace the current cursor logic however as the cursor-shape-enum misses quite a few cursors available in the theme, it's likely we would want to keep both - which is possible but gets fairly messy.

Also, when transforming there is a visible flicker when setting the cursor before software cursor is enabled.

Putting this PR on hold.

Created for reference but closing as properly managing buffer-cursors, shape-cursors & cursors-in-software is becoming unreasonably complicated. Ideally this would be able to replace the current cursor logic however as the cursor-shape-enum misses quite a few cursors available in the theme, it's likely we would want to keep both - which is possible but gets fairly messy. Also, when transforming there is a visible flicker when setting the cursor before software cursor is enabled. Putting this PR on hold.

Campbell Barton closed this pull request

2023-12-02 10:47:26 +01:00

Campbell Barton referenced this pull request

2023-12-02 10:53:00 +01:00

GHOST/Wayland Support #76428