Compositor: Add High Precision option to Kuwahara #115763

Merged

Omar Emara merged 3 commits from OmarEmaraDev/blender:high-precision-classic-kuwahara into main

2024-01-17 14:30:39 +01:00

Omar Emara commented

2023-12-04 17:08:18 +01:00

Member

For high radii Kuwahara, we use a Summed Area Table (SAT) implementation
to accelerate the classic variant of the algorithm. The problem is that
due to limited floating point precision, the SAT can produce artifacts
in its output.

An attempt to fix this was implemented in #114191, and while that patch
improved precision by 10x, the artifacts still existed, albeit less
noticeable. But since the improved precision also meant a performance
penalty, it was decided that the improvement is not worth it.

Since the artifacts are only noticeable for scenes with very high
values, this patch adds a High Precision option that defaults to false
and can be enabled by the user upon noticing any artifacts. The option
simply uses direction convolution instead of SAT in this case. The
downside, of course, is that it can be orders of magnitude slower.

An alternative to using this option is for the user to clamp the input
or downsample the image. Both methods should be documented in the
documentation.

Fixes: #113578.

For high radii Kuwahara, we use a Summed Area Table (SAT) implementation to accelerate the classic variant of the algorithm. The problem is that due to limited floating point precision, the SAT can produce artifacts in its output. An attempt to fix this was implemented in #114191, and while that patch improved precision by 10x, the artifacts still existed, albeit less noticeable. But since the improved precision also meant a performance penalty, it was decided that the improvement is not worth it. Since the artifacts are only noticeable for scenes with very high values, this patch adds a High Precision option that defaults to false and can be enabled by the user upon noticing any artifacts. The option simply uses direction convolution instead of SAT in this case. The downside, of course, is that it can be orders of magnitude slower. An alternative to using this option is for the user to clamp the input or downsample the image. Both methods should be documented in the documentation. Fixes: #113578.

Omar Emara added the

labels 2023-12-04 17:08:18 +01:00

Omar Emara added 1 commit 2023-12-04 17:08:27 +01:00

504efd345d Compositor: Add High Precision option to Kuwahara

For high radii Kuwahara, we use a Summed Area Table (SAT) implementation
to accelerate the classic variant of the algorithm. The problem is that
due to limited floating point precision, the SAT can produce artifacts
in its output.

An attempt to fix this was implemented in #114191, and while that patch
improved precision by 10x, the artifacts still existed, albeit less
noticeable. But since the improved precision also meant a performance
penalty, it was decided that the improvement is not worth it.

Since the artifacts are only noticeable for scenes with very high
values, this patch adds a High Precision option that defaults to false
and can be enabled by the user upon noticing any artifacts. The option
simply uses direction convolution instead of SAT in this case. The
downside, of course, is that it can be orders of magnitude slower.

An alternative to using this option is for the user to clamp the input
or downsample the image. Both methods should be documented in the
documentation.

Fixes: #113578.

Omar Emara requested review from Sergey Sharybin 2023-12-04 17:08:45 +01:00

Sergey Sharybin requested changes 2024-01-17 12:55:21 +01:00

Sergey Sharybin left a comment

Owner

The convention is that boolean RNA properties should start with use_, so more proper name would be use_high_precision.

Other than that the patch looks good.

The convention is that boolean RNA properties should start with `use_`, so more proper name would be `use_high_precision`. Other than that the patch looks good.

Omar Emara added 2 commits 2024-01-17 14:21:28 +01:00

0015755e44 Merge branch 'main' into high-precision-classic-kuwahara

eac2b27444 Rename RNA to use_high_precision

Sergey Sharybin approved these changes 2024-01-17 14:28:14 +01:00

Omar Emara merged commit e4a93d7b8c into main

2024-01-17 14:30:39 +01:00

Omar Emara deleted branch high-precision-classic-kuwahara

2024-01-17 14:30:50 +01:00

Omar Emara referenced this issue from a commit

2024-01-17 14:30:50 +01:00

Compositor: Add High Precision option to Kuwahara

Arye Ramaty referenced this issue from a commit

2024-01-21 15:37:42 +01:00

Compositor: Add High Precision option to Kuwahara

Jonas Dichelle referenced this issue from a commit

2024-02-08 17:29:03 +01:00

Compositor: Add High Precision option to Kuwahara

Sign in to join this conversation.

No reviewers

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#115763

No description provided.