Fix #115662: Outliner slows down many geometry operations in big scenes #115799

Philipp Oeser · 2023-12-05T14:01:30+01:00

Philipp Oeser commented

2023-12-05 14:01:30 +01:00

This was reported for UV editing but also e.g. some modeling operations
were affected.

In 295bc1249a, a listener for NC_GEOM > ND_DATA was added to the
Outliner in order to update when renaming bones (c4622c405e).
Since we are only interested in the naming part (no need to update the
Outliner otherwise), the notifier/listener combo was made more specific
by including the NA_RENAME action here.

Since this was a very general thing to listen to, other operations might
have relied on this to properly update, but having checked many things,
I could spot only one case where an Outliner update was missing after
the initial change and that was adding images.
This case was added separately now.

This was reported for UV editing but also e.g. some modeling operations were affected. In 295bc1249a85, a listener for `NC_GEOM` > `ND_DATA` was added to the Outliner in order to update when renaming bones (c4622c405e40). Since we are only interested in the naming part (no need to update the Outliner otherwise), the notifier/listener combo was made more specific by including the `NA_RENAME` action here. Since this was a very general thing to listen to, other operations might have relied on this to properly update, but having checked many things, I could spot only one case where an Outliner update was missing after the initial change and that was adding images. This case was added separately now.

Philipp Oeser added 1 commit 2023-12-05 14:01:41 +01:00

740ca1b858 Fix #115662 : Outliner slows down many geometry operations in big scenes

This was reported for UV editing but also e.g. some modeling operations
were affected.

In 295bc1249a, a listener for `NC_GEOM` > `ND_DATA` was added to the
Outliner in order to update when renaming bones (c4622c405e).
Since we are only interested in the naming part (no need to update the
Outliner otherwise), the notifier/listener combo was made more specific
by including the `NA_RENAME` action here.

Since this was a very general thing to listen to, other operations might
have relied on this to properly update, but having checked many things,
I could spot only one case where an Outliner update was missing after
the initial change and that was adding images (this was notifiying XXX).
This case was added separately now.

Philipp Oeser requested review from Julian Eisel 2023-12-05 14:01:54 +01:00

Philipp Oeser requested review from Bastien Montagne 2023-12-05 14:02:01 +01:00

Philipp Oeser added this to the User Interface project 2023-12-05 14:02:09 +01:00

Bastien Montagne approved these changes 2023-12-05 18:00:34 +01:00

Bastien Montagne left a comment

LGTM

Philipp Oeser merged commit 94defad5f1 into main

2023-12-06 10:23:07 +01:00

Philipp Oeser deleted branch 115662

2023-12-06 10:23:09 +01:00

Philipp Oeser referenced this issue from a commit

2023-12-06 10:23:11 +01:00

Fix #115662: Outliner slows down many geometry operations in big scenes

Brian Savery (AMD) referenced this issue from a commit

2023-12-28 20:07:43 +01:00

Fix #115662: Outliner slows down many geometry operations in big scenes

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Fix #115662: Outliner slows down many geometry operations in big scenes #115799