blender-v3.3-release backports #115848

Philipp Oeser · 2023-12-06T15:39:49+01:00

Philipp Oeser commented

2023-12-06 15:39:49 +01:00

No response

_No response_

Philipp Oeser added 3 commits 2023-12-06 15:39:58 +01:00

6b09a0277b Fix #113325 : Zero-sized curve leads to OptiX error

Empty hair geometry in Cycles may still report having one curve, even when
there are no actual segments in that curve. This caused an attempt to build
an acceleration structure with zero primitives, which due to other setup
OptiX rejected with an error. Fix that by checking the number of segments
rather than the number of curves in the hair geometry, since the former will
always be zero for empty geometry.

Pull Request: #115044

843b3b3705 Fix #114557 : UI scrollbar "focus bubble" interaction wrong in cases

Some Editors like the Filebrowser or Spreadsheet set up custom masks for
scrollbars (they dont cover the whole region width or height, some rows
or colums are excluded here -- e.g. the "index" column in the
Spreadsheet), this was working fine for drawing, but mouse interaction
was ignoring these custom masks.

Symptoms were that clicking on the "focus bubble" of the scrollbar and
dragging would not result in smooth scrolling [because internally code
would assume the mouse was clicking outside], instead scroll by 1 'page'
was happening [was perceived as a massive lag]. Especially noticable
with many rows/columns (where the "focus bubble" gets small).

So for drawing (`UI_view2d_scrollers_draw`) this wasnt a problem, masks
were passed in for `view2d_scrollers_calc`.
But for interaction (`scroller_activate_init`) `view2d_scrollers_calc`
is called again and a NULL mask was passed.

The already set up rects need to be considered though, otherwise coords
for `mouse_in_scroller_handle` later are not compatible.
To fix this, use existing `View2D` rects fors scrollbars, and pass a
union of those as `mask_custom` to `view2d_scrollers_calc`.

NOTE: this can temporarily extend the `View2D` scrollbar rect by a
pixel, the next draw call will correct this again though.

Pull Request: #114631

buildbot/vexp-code-patch-coordinator Build done. Details

19a03bd66e Fix #115363 : Scrollbars for template_lists in popups update issue

Scrollbars in popups need UI layout refresh to update the right items to
show correctly.

Pull Request: #115364

Philipp Oeser commented

2023-12-06 15:40:09 +01:00

@blender-bot build

Philipp Oeser referenced this issue from a commit

2023-12-06 16:15:47 +01:00

Fix #115363: Scrollbars for template_lists in popups update issue

Philipp Oeser merged commit b5db5303f1 into blender-v3.3-release

2023-12-06 16:15:47 +01:00

Philipp Oeser deleted branch blender-v3.3-release

2023-12-06 16:15:49 +01:00

Sign in to join this conversation.

No reviewers

No Label

Asset Browser Project Overview

Development Management

Pipeline, Assets & IO

Interest

Platforms, Builds & Tests

Sculpt, Paint & Texture

Milestone 1: Basic, Local Asset Browser

Development Management

Pipeline, Assets & IO

Module

Platforms, Builds & Tests

Sculpt, Paint & Texture

Needs Info from Developers

Status

Needs Information from User

No Milestone

No project

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#115848

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

blender-v3.3-release backports #115848