UI: Remove unnecessary empty spaces in Custom Properties panels #115913

Nika Kutsniashvili · 2023-12-07T21:51:25+01:00

2023-12-07 21:51:25 +01:00

Removes unnecessary empty space in Custom Properties panels by adding align=True to row. Gives properties bit more space and makes them more readable and aligned.

In Properties panel that is in the 'Sidebar - Item', empty space was created purposefully on the right hand side, with comment saying so that it lines up with layout and decorations. I have to assume either this is comment from pre-2.80 times, or they mean to align with lock property icons in Transform panels. Either way, I think this is outdated and makes properties misaligned, so I removed the empty space. This will give rig properties more space in already thin UI

Before	After

Removes unnecessary empty space in Custom Properties panels by adding align=True to row. Gives properties bit more space and makes them more readable and aligned. In Properties panel that is in the 'Sidebar - Item', empty space was created purposefully on the right hand side, with comment saying so that it lines up with layout and decorations. I have to assume either this is comment from pre-2.80 times, or they mean to align with lock property icons in Transform panels. Either way, I think this is outdated and makes properties misaligned, so I removed the empty space. This will give rig properties more space in already thin UI | Before | After | | -------- | -------- | | ![properties_before.png](/attachments/72560603-395d-4e0c-ab77-9e4db3c1f967) | ![properties_after.png](/attachments/b47ebfc1-4578-4f62-9242-d60e8390622f) | | ![sidebar_before.png](/attachments/c50a6965-0281-46f0-8fe4-c50f0e3fd7ca) | ![sidebar_after.png](/attachments/4fa2d731-d7f6-4790-9aa6-8b5572767586) |

sidebar_after.png

6.9 KiB

properties_after.png

7.4 KiB

properties_before.png

7.5 KiB

sidebar_before.png

7.0 KiB

👍 1 🚀 1

Nika Kutsniashvili added 1 commit 2023-12-07 21:51:38 +01:00

f16ba08422 Remove unnecessary empty spaces in Custom Properties panels

Nika Kutsniashvili requested review from Harley Acheson 2023-12-07 21:53:00 +01:00

RedMser reviewed 2023-12-08 01:23:00 +01:00

scripts/modules/rna_prop_ui.py Outdated

						
				@ -235,3 +235,1 @@

				        else:

				            # Add some spacing, so the right side of the buttons line up with layouts with decorators.

				            operator_row.label(text="", icon='BLANK1')

				        # else:

RedMser commented

2023-12-08 01:23:00 +01:00

You should remove unused code instead of commenting it out.

👍 1

Nika Kutsniashvili commented

2023-12-08 10:39:51 +01:00

Yeah I wasnt sure about guideline on that so waited for a reply.

nickberckley marked this conversation as resolved

Iliya Katushenock added this to the User Interface project 2023-12-08 08:07:30 +01:00

Nika Kutsniashvili added 1 commit 2023-12-08 15:46:09 +01:00

ed9f103156 Remove unnecessary code

Pablo Vazquez reviewed 2024-02-05 12:36:45 +01:00

Pablo Vazquez left a comment

...comment saying so that it lines up with layout and decorations. I have to assume either this is comment from pre-2.80 times

Decorators were introduced in 2.80.

You can do git blame or use a kind of git lens plugin on your IDE to see the commits for a specific line and who made it. To understand a bit better why specific changes are made. This line in particular was introduced by @HooglyBoogly in D12805 so it's good to ask him before making any changes.

> ...comment saying so that it lines up with layout and decorations. I have to assume either this is comment from pre-2.80 times Decorators were introduced in 2.80. You can do `git blame` or use a kind of git lens plugin on your IDE to see the commits for a specific line and who made it. To understand a bit better why specific changes are made. This line in particular was introduced by @HooglyBoogly in [D12805](https://archive.blender.org/developer/D12805) so it's good to ask him before making any changes.

👍 1

Hans Goudey commented

2024-02-05 14:28:38 +01:00

Yeah, this seems fine. Nothing really lines up very well here anyway.

👍 1

Pablo Vazquez approved these changes 2024-02-05 14:32:09 +01:00

Pablo Vazquez merged commit 2274f58ef2 into main

2024-02-05 14:34:25 +01:00

Pablo Vazquez referenced this issue from a commit

2024-02-05 14:34:25 +01:00

UI: Remove empty space in Custom Properties panel

Pablo Vazquez deleted branch custom-properties-panel