Fix #100784: Truncate Text with Ellipsis inside Number Inputs #115958

Harley Acheson · 2023-12-08T22:11:38+01:00

Harley Acheson commented

2023-12-08 22:11:38 +01:00

When a property name is shown inside of a numerical input, truncate
with ellipsis if it cannot fit.

We current don't truncate with ellipsis for UI_BTYPE_NUM and UI_BTYPE_NUM_SLIDER, but just remove characters. Probably because these have the complication of looking like "this is long text :0.00" so we have to deal with the trailing value.

This PR just adds an early exit if the string fits. If not the string measurement is done with the length of ellipsis considered. And then inserts that character at the end if it can.

The example in the report:

After this PR is applied:

When a property name is shown inside of a numerical input, truncate with ellipsis if it cannot fit. --- We current don't truncate with ellipsis for `UI_BTYPE_NUM` and `UI_BTYPE_NUM_SLIDER`, but just remove characters. Probably because these have the complication of looking like "this is long text :0.00" so we have to deal with the trailing value. This PR just adds an early exit if the string fits. If not the string measurement is done with the length of ellipsis considered. And then inserts that character at the end if it can. The example in the report: ![image](/attachments/4795a701-3312-496d-a1c3-2b169da5b22e) After this PR is applied: ![image](/attachments/e69a81c3-cfb4-48d2-857e-f06aee0250cf)

image.png

34 KiB

image.png

24 KiB

Harley Acheson added 1 commit 2023-12-08 22:11:48 +01:00

3ef9155858 Fix #100784 : Truncate Text with Ellipsis inside Number Inputs

When a property name is shown inside of a numerical input, truncate
with ellipsis if it cannot fit.

---

We current don't truncate with ellipsis for `UI_BTYPE_NUM` and `UI_BTYPE_NUM_SLIDER`, but just remove characters. Probably because these have the complication of looking like "this is long text :0.00" so we have to deal with the trailing value.

This PR just adds an early exit if the string fits. If not the string measurement is done with the length of ellipsis considered. And then inserts that character at the end if it can.

Harley Acheson added 1 commit 2023-12-08 22:16:11 +01:00