Geometry Nodes: Add Rotate Rotation node #116106

Merged
Hans Goudey merged 6 commits from HooglyBoogly/blender:geometry-nodes-rotate-rotation into main 2024-02-01 14:29:42 +01:00
Member

This is meant as a replacement for the Rotate Euler node. Overall it
should be more performant, and the clarity given by the separate socket
type should help distinguish its purpose.

The Rotate Euler node is removed from search and the add menu by this
commit. In the future it can be versioned away. That isn't done now to
avoid a breaking API change and to make this commit less risky.

This is meant as a replacement for the Rotate Euler node. Overall it should be more performant, and the clarity given by the separate socket type should help distinguish its purpose. The Rotate Euler node is removed from search and the add menu by this commit. In the future it can be versioned away. That isn't done now to avoid a breaking API change and to make this commit less risky.
Hans Goudey added 2 commits 2023-12-12 19:37:29 +01:00
This is meant as a replacement for the Rotate Euler node. Overall it
should be more performant, and the clarity given by the separate socket
type should help distinguish its purpose.

The Rotate Euler node is removed from search and the add menu by this
commit. In the future it can be versioned away. That isn't done now to
avoid a breaking API change and to make this commit less risky.
Hans Goudey requested review from Jacques Lucke 2023-12-12 19:37:48 +01:00
Hans Goudey added the
Module
Nodes & Physics
Interest
Geometry Nodes
labels 2023-12-12 19:37:57 +01:00
Hans Goudey added this to the 4.1 milestone 2023-12-12 19:38:02 +01:00
Hans Goudey added this to the Nodes & Physics project 2023-12-12 19:38:10 +01:00
Hans Goudey added 1 commit 2024-01-11 16:40:13 +01:00
Hans Goudey added 1 commit 2024-01-23 18:03:33 +01:00
Jacques Lucke requested changes 2024-01-24 11:29:49 +01:00
Jacques Lucke left a comment
Member

oops, wrong patch

_oops, wrong patch_
Member

It seems to me that the order of inputs is reversed, i.e. the second rotation comes first and then the other. Please double check that.

It seems to me that the order of inputs is reversed, i.e. the second rotation comes first and then the other. Please double check that.
Iliya Katushenock reviewed 2024-01-24 11:57:48 +01:00
@ -0,0 +12,4 @@
{
b.is_function_node();
b.add_input<decl::Rotation>("Rotation 1");
b.add_input<decl::Rotation>("Rotation 2");

What do you think about Space Rotation * Rotation naming?

What do you think about `Space Rotation` * `Rotation` naming?
Author
Member

I'd be fine with that too, but without discussing it more I'd rather be more conservative and go with the existing naming conventions now.

I'd be fine with that too, but without discussing it more I'd rather be more conservative and go with the existing naming conventions now.
Author
Member

I don't have an opinion on the order really, I don't have an intuition for the order of inputs of these nodes with non-commutative operations and have just based the choice on feedback in the past. But I reversed the order in the PR now.

I don't have an opinion on the order really, I don't have an intuition for the order of inputs of these nodes with non-commutative operations and have just based the choice on feedback in the past. But I reversed the order in the PR now.
Hans Goudey added 2 commits 2024-01-30 04:47:12 +01:00
Jacques Lucke approved these changes 2024-02-01 14:25:15 +01:00
Hans Goudey merged commit f4867c0d70 into main 2024-02-01 14:29:42 +01:00
Hans Goudey deleted branch geometry-nodes-rotate-rotation 2024-02-01 14:29:44 +01:00
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Code Documentation
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#116106
No description provided.