Fix: Set active keying set menu showing wrong label #116189

Merged
Christoph Lendenfeld merged 3 commits from ChrisLend/blender:fix_active_keying_set_label into main 2024-01-04 16:38:24 +01:00

When opening the menu to set/change the
active keying set, the top entry would
show "Active Keying Set" (if there is one).
(Open the menu with Ctrl+Shift+Alt+I)

Clicking this option would unset the active keying set
though as pointed out by Nika Kutsniashvili in #115798: Anim: Add hotkey for keying set operators

This PR fixes it by splitting the function that dynamically generates the enum.
The core of the function has been extracted, and only the section
that creates the entry for "Active Keying Set" has been changed.

It now reads "Clear Active Keying Set"

Depends on: #116332

Before After
image image
When opening the menu to set/change the active keying set, the top entry would show "Active Keying Set" (if there is one). (Open the menu with Ctrl+Shift+Alt+I) Clicking this option would unset the active keying set though as pointed out by Nika Kutsniashvili in [#115798: Anim: Add hotkey for keying set operators](https://projects.blender.org/blender/blender/pulls/115798) This PR fixes it by splitting the function that dynamically generates the enum. The core of the function has been extracted, and only the section that creates the entry for "Active Keying Set" has been changed. It now reads "Clear Active Keying Set" Depends on: #116332 | Before | After | | - | - | | ![image](/attachments/5d563c22-226b-4d00-bfed-5d8bdb39d9f6) | ![image](/attachments/9491b67c-ea2c-4f4d-a252-ac9dd1e5b8c4) |
Christoph Lendenfeld added the
Module
Animation & Rigging
label 2023-12-14 15:29:27 +01:00
Christoph Lendenfeld added 1 commit 2023-12-14 15:29:36 +01:00
Contributor

Wouldn't it be more comfortable if it was last? First one is easy to misclick, especially when you have custom keying sets right under there

Wouldn't it be more comfortable if it was last? First one is easy to misclick, especially when you have custom keying sets right under there
Author
Member

Wouldn't it be more comfortable if it was last? First one is easy to misclick, especially when you have custom keying sets right under there

I kept it in the same place because it is consistent with the "apply keyingset" menu. Active keyingset is in the same spot.
We can move it, but I would make that a separate PR because it's not related to this fix.

> Wouldn't it be more comfortable if it was last? First one is easy to misclick, especially when you have custom keying sets right under there I kept it in the same place because it is consistent with the "apply keyingset" menu. Active keyingset is in the same spot. We can move it, but I would make that a separate PR because it's not related to this fix.
Sybren A. Stüvel requested changes 2023-12-19 10:55:24 +01:00
Sybren A. Stüvel left a comment
Member

I think the approach here is good, but I think it's clearer if this PR were to be split.

This PR fixes it by splitting the function that dynamically generates the enum.
The core of the function has been extracted, and only the section
that creates the entry for "Active Keying Set" has been changed.

If these two steps would be two commits, the functional changes will stand out much clearer.
And then I can review without requiring too much brain ;-)

I think the approach here is good, but I think it's clearer if this PR were to be split. > This PR fixes it by splitting the function that dynamically generates the enum. > The core of the function has been extracted, and only the section > that creates the entry for "Active Keying Set" has been changed. If these two steps would be two commits, the functional changes will stand out much clearer. And then I can review without requiring too much brain ;-)
Author
Member
Split off the code extraction: [#116332: Refactor: extract code from ANIM_keying_sets_enum_itemf](https://projects.blender.org/blender/blender/pulls/116332)
Christoph Lendenfeld added 2 commits 2024-01-04 11:34:14 +01:00
Christoph Lendenfeld requested review from Sybren A. Stüvel 2024-01-04 11:35:05 +01:00
Author
Member

@dr.sybren now that the refactor PR has landed, this should be easier to review

@dr.sybren now that the refactor PR has landed, this should be easier to review
Sybren A. Stüvel approved these changes 2024-01-04 16:15:23 +01:00
Sybren A. Stüvel left a comment
Member

👍

:+1:
Christoph Lendenfeld merged commit 29ed7a69e6 into main 2024-01-04 16:38:24 +01:00
Christoph Lendenfeld deleted branch fix_active_keying_set_label 2024-01-04 16:38:26 +01:00
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Code Documentation
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#116189
No description provided.