UI: Show "No results found" for empty searches #116201

Harley Acheson · 2023-12-14T18:35:58+01:00

Harley Acheson commented

2023-12-14 18:35:58 +01:00

For menu and operator searches, and for File and Asset Browser
filtering, show "No Results Found" when there is nothing to show.

We currently just show empty result lists when nothing matches a search or filter. But this could be confused by users as a result still in progress. This PR just displays "No Results Found" in this case.

For menu and operator searches it looks like this:

Here is an empty Asset list:

Different (and brighter) text when the filtering gives no results

For menu and operator searches, and for File and Asset Browser filtering, show "No Results Found" when there is nothing to show. --- We currently just show empty result lists when nothing matches a search or filter. But this could be confused by users as a result still in progress. This PR just displays "No Results Found" in this case. For menu and operator searches it looks like this: ![image](/attachments/4832077d-9376-4aed-8113-1ab614abc7ae) Here is an empty Asset list: ![image](/attachments/fcb5de61-bf1b-4d23-bf01-d9335d17d693) Different (and brighter) text when the filtering gives no results ![image](/attachments/c45dcef5-e8af-4cb8-82ef-9cd9791a11e3)

image.png

18 KiB

image.png

18 KiB

image.png

37 KiB

image.png

8.3 KiB

👍 3

Harley Acheson added 1 commit 2023-12-14 18:36:08 +01:00

dc31184592 UI: Show "No results found" for empty searches

For menu and operator searches, and for File and Asset Browser
filtering, show "No Results Found" when there is nothing to show.

Harley Acheson added this to the User Interface project 2023-12-14 18:36:24 +01:00

Brecht Van Lommel commented

2023-12-14 19:02:34 +01:00

I think the text should be different depending if anything was searched for, or if there's just nothing there.

Harley Acheson commented

2023-12-14 19:15:47 +01:00

I think the text should be different depending if anything was searched for, or if there's just nothing there.

Yes, me too.

"No results found" for searches or filtering. Or perhaps just "No results". I think I prefer "No results found"

Otherwise could be "Empty", "None", "No Items", "Nothing", "Blank", "No data". Yuck.

> I think the text should be different depending if anything was searched for, or if there's just nothing there. Yes, me too. "No results found" for searches or filtering. Or perhaps just "No results". I think I prefer "No results found" Otherwise could be "Empty", "None", "No Items", "Nothing", "Blank", "No data". Yuck.

Harley Acheson added 1 commit 2023-12-14 20:24:42 +01:00

2c5bace758 Differing messages for Files/Assets while filtering

Harley Acheson changed title from ~~WIP: UI: Show "No results found" for empty searches~~ to UI: Show "No results found" for empty searches

2023-12-15 04:23:16 +01:00

Harley Acheson requested review from Julian Eisel 2023-12-15 04:23:25 +01:00

Harley Acheson added 1 commit 2023-12-20 01:23:52 +01:00

400c619189 Merge branch 'main' of projects.blender.org:blender/blender into EmptySearch

Brecht Van Lommel reviewed 2023-12-20 13:24:43 +01:00

source/blender/editors/space_file/file_draw.cc Outdated

						
				@ -1169,0 +1180,4 @@

				    }

				    const char *message = is_filtered ? IFACE_("No results match your search filter") :

				                                        IFACE_("No Items");