Fix #105548: I18n: many keymap sections cannot be translated #116299

Damien Picard · 2023-12-18T13:46:55+01:00

Damien Picard commented

2023-12-18 13:46:55 +01:00

In the keymap user preferences, shortcuts are grouped according to a
hierarchy of topics. Some of them cannot be translated, as they do not
get extracted by the i18n script. The issue happens in
walk_keymap_hierarchy(). If the item in the hierarchy is not a
string, it is skipped. This happens for tools defining their own
keymap, because they use a function instead of a string as the name.

In turn, the issue is in keymap_hierarchy.generate(). If run in the
interface, the hierarchy will contain only strings as topic names.
However, if run in the background, some of them will still be
functions, because they are not initialized.

This commit makes keyconfig initialization run in the background as
well.

I’m not entirely sure this is the proper fix. WM_check() is called when a file is opened or when a new window is created, but I’m not sure why the keyconfig init must be run at that point and not on startup. The current fix is simply to move WM_keyconfig_init() outside of the background check but maybe it should be moved somewhere else entirely?

In the keymap user preferences, shortcuts are grouped according to a hierarchy of topics. Some of them cannot be translated, as they do not get extracted by the i18n script. The issue happens in `walk_keymap_hierarchy()`. If the item in the hierarchy is not a string, it is skipped. This happens for tools defining their own keymap, because they use a function instead of a string as the name. In turn, the issue is in `keymap_hierarchy.generate()`. If run in the interface, the hierarchy will contain only strings as topic names. However, if run in the background, some of them will still be functions, because they are not initialized. This commit makes keyconfig initialization run in the background as well. ----- I’m not entirely sure this is the proper fix. `WM_check()` is called when a file is opened or when a new window is created, but I’m not sure why the keyconfig init must be run at that point and not on startup. The current fix is simply to move `WM_keyconfig_init()` outside of the background check but maybe it should be moved somewhere else entirely?

Damien Picard added 1 commit 2023-12-18 13:47:04 +01:00

832208f857 Fix #105548 : I18n: many keymap sections cannot be translated

In the keymap user preferences, shortcuts are grouped according to a
hierarchy of topics. Some of them cannot be translated, as they do not
get extracted by the i18n script. The issue happens in
`walk_keymap_hierarchy()`. If the item in the hierarchy is not a
string, it is skipped. This happens for tools defining their own
keymap, because they use a function instead of a string as the name.

In turn, the issue is in `keymap_hierarchy.generate()`. If run in the
interface, the hierarchy will contain only strings as topic names.
However, if run in the background, some of them will still be
functions, because they are not initialized.

This commit makes keyconfig initialization run in the background as
well.

Damien Picard added the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Fix #105548: I18n: many keymap sections cannot be translated #116299

Pull request closed