Fix #116239: Propagate to Shapes overwrites all vertices with mirroring #116329

Merged
Philipp Oeser merged 1 commits from lichtwerk/blender:116239 into main 2023-12-19 12:35:08 +01:00
Member

Since 4d0dbab5b1, EDBM_verts_mirror_cache is used to find mirror
verts (but this was initialized with use_select being true, so the
cache was only set up for selected verts). EDBM_verts_mirror_get
behaves in a way that if you then query a vert that does not have a true
mirror, it would always return the vert with index zero in this case (so
basically would look like the index zero vert is the mirror for verts
not covered in the cache). Now if that zero index vert happened to be
selected, verts would not be skipped and the whole mesh would be
overwritten.

To solve this, we need to initialize the EDBM_verts_mirror_cache with
use_select being false -- this way all verts are covered and we
always get back the true mirror (checking selection on that one is fine
then and everything behaves as expected).

Since 4d0dbab5b1bf, `EDBM_verts_mirror_cache` is used to find mirror verts (but this was initialized with `use_select` being `true`, so the cache was only set up for selected verts). `EDBM_verts_mirror_get` behaves in a way that if you then query a vert that does not have a true mirror, it would always return the vert with index zero in this case (so basically would look like the index zero vert is the mirror for verts not covered in the cache). Now if that zero index vert happened to be selected, verts would not be skipped and the whole mesh would be overwritten. To solve this, we need to initialize the `EDBM_verts_mirror_cache` with `use_select` being `false` -- this way all verts are covered and we always get back the true mirror (checking selection on that one is fine then and everything behaves as expected).
Philipp Oeser added 1 commit 2023-12-19 11:42:09 +01:00
Since 4d0dbab5b1, `EDBM_verts_mirror_cache` is used to find mirror
verts (but this was initialized with `use_select` being `true`, so the
cache was only set up for selected verts). `EDBM_verts_mirror_get`
behaves in a way that if you then query a vert that does not have a true
mirror, it would always return the vert with index zero in this case (so
basically would look like the index zero vert is the mirror for verts
not covered in the cache). Now if that zero index vert happened to be
selected, verts would not be skipped and the whole mesh would be
overwritten.

To solve this, we need to initialize the `EDBM_verts_mirror_cache` with
`use_select` being `false` -- this way all verts are covered and we
always get back the true mirror (checking selection on that one is fine
then and everything behaves as expected).
Philipp Oeser added this to the Modeling project 2023-12-19 11:42:23 +01:00
Philipp Oeser added the
Interest
Animation & Rigging
label 2023-12-19 11:42:30 +01:00
Philipp Oeser requested review from Brecht Van Lommel 2023-12-19 11:42:37 +01:00
Philipp Oeser requested review from Campbell Barton 2023-12-19 11:42:43 +01:00
Philipp Oeser requested review from Alexander Gavrilov 2023-12-19 11:42:50 +01:00
Brecht Van Lommel approved these changes 2023-12-19 11:50:26 +01:00
Philipp Oeser merged commit 820a0f7240 into main 2023-12-19 12:35:08 +01:00
Philipp Oeser deleted branch 116239 2023-12-19 12:35:10 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#116329
No description provided.