Realtime Compositor: Implement Defocus node #116391

Merged

Omar Emara merged 2 commits from OmarEmaraDev/blender:gpu-defocus-node into main

2023-12-21 12:20:49 +01:00

Omar Emara commented

2023-12-20 19:20:25 +01:00

Member

This patch implements the defocus node for the Realtime Compositor. The
implementation does not match the CPU compositor implementation, but
uses a new formulation that is more physically accurate and consistent
with Blender's render engines.

The existing CPU implementation is questionable starting from its circle
of confusion calculation, to the morphological operations applied on the
CoC radius, to ignoring the maximum CoC radius in the search kernel, and
ending with the threshold parameter used to reduce artifacts. Therefore,
it should be reimplemented along with this same implementation using a
more consistent methodology.

EEVEE and Workbench already have a GPU defocus method, which can be
ported to the compositor and used as the preview defocus algorithm.
While this implementation will be updated to be a more accurate method
that produces the same structure as the ported EEVEE implementation.

The new formulation ignores the threshold parameter for now, as well as
the preview parameter.

This patch implements the defocus node for the Realtime Compositor. The implementation does not match the CPU compositor implementation, but uses a new formulation that is more physically accurate and consistent with Blender's render engines. The existing CPU implementation is questionable starting from its circle of confusion calculation, to the morphological operations applied on the CoC radius, to ignoring the maximum CoC radius in the search kernel, and ending with the threshold parameter used to reduce artifacts. Therefore, it should be reimplemented along with this same implementation using a more consistent methodology. EEVEE and Workbench already have a GPU defocus method, which can be ported to the compositor and used as the preview defocus algorithm. While this implementation will be updated to be a more accurate method that produces the same structure as the ported EEVEE implementation. The new formulation ignores the threshold parameter for now, as well as the preview parameter.

Omar Emara added the

labels 2023-12-20 19:20:25 +01:00

Omar Emara added 1 commit 2023-12-20 19:20:35 +01:00

909d524cfc Realtime Compositor: Implement Defocus node

This patch implements the defocus node for the Realtime Compositor. The
implementation does not match the CPU compositor implementation, but
uses a new formulation that is more physically accurate and consistent
with Blender's render engines.

The existing CPU implementation is questionable starting from its circle
of confusion calculation, to the morphological operations applied on the
CoC radius, and ending with the threshold parameter used to reduce bad
artifacts. Therefore, it should be reimplemented along with this same
implementation using a more consistent methodology.

EEVEE and Workbench already have a GPU defocus method, which can be
ported to the compositor and used as the preview defocus algorithm.
While this implementation will be updated to be a more accurate method
that produces the same structure as the ported EEVEE implementation.

The new formulation ignores the threshold parameter for now, as well as
the preview parameter.

Omar Emara commented

2023-12-20 19:28:03 +01:00

Author

Member

I more or less gave up on reverse-engineering the method used by the CPU node and opted to just use a method that is more consistent with the rest of Blender. Then we can update both implementations to use a more consistent methodology.

Ground truth (Cycles) vs GPU compositor:

Ground truth (Cycles) vs Full Frame compositor:

Workbench DOF vs GPU compositor:

I more or less gave up on reverse-engineering the method used by the CPU node and opted to just use a method that is more consistent with the rest of Blender. Then we can update both implementations to use a more consistent methodology. --- --- Ground truth (Cycles) vs GPU compositor: ![20231220-194446.png](/attachments/829bd47b-1ca2-4291-af2f-a8cef5b6f167) Ground truth (Cycles) vs Full Frame compositor: ![20231220-194419.png](/attachments/bbe2458d-137a-4425-8d75-7068cfa217bb) Workbench DOF vs GPU compositor: ![20231220-195055.png](/attachments/1fc9e2a8-227f-4c7e-864d-dd7ddfa2d018)

20231220-194419.png

572 KiB

20231220-194446.png

573 KiB

20231220-195055.png

570 KiB

Omar Emara requested review from Brecht Van Lommel 2023-12-20 19:29:38 +01:00

Brecht Van Lommel approved these changes 2023-12-20 19:49:59 +01:00

Brecht Van Lommel commented

2023-12-20 19:53:00 +01:00

Owner

For vector blur I guess you would do the same, use the EEVEE (Next) implementation instead?

Trying to port that CPU implementation to the GPU does not seems particularly useful, it's complicated and doesn't give particularly good results.

For vector blur I guess you would do the same, use the EEVEE (Next) implementation instead? Trying to port that CPU implementation to the GPU does not seems particularly useful, it's complicated and doesn't give particularly good results.

Omar Emara commented

2023-12-20 20:09:39 +01:00

Author

Member

I haven't looked at the EEVEE implementation yet, but we might indeed do that directly, as I already looked at the Vector Blur code and it seem it would be rather hard to port as well.

I haven't looked at the EEVEE implementation yet, but we might indeed do that directly, as I already looked at the Vector Blur code and it seem it would be rather hard to port as well.

Omar Emara added 1 commit 2023-12-21 12:19:42 +01:00

27178e9a22 Improve clarity

Omar Emara merged commit e055db6605 into main

2023-12-21 12:20:49 +01:00

Omar Emara referenced this issue from a commit

2023-12-21 12:20:49 +01:00

Realtime Compositor: Implement Defocus node

Omar Emara deleted branch gpu-defocus-node

2023-12-21 12:20:51 +01:00

Guillermo Venegas referenced this issue from a commit

2023-12-26 22:06:36 +01:00

Realtime Compositor: Implement Defocus node

Brian Savery (AMD) referenced this issue from a commit

2023-12-28 20:07:46 +01:00

Realtime Compositor: Implement Defocus node

Brecht Van Lommel added the

label 2024-01-15 13:28:11 +01:00

Brecht Van Lommel commented

2024-01-15 13:28:31 +01:00

Owner

Comment for testing, please ignore.

Comment for testing, please ignore.

Sign in to join this conversation.

No reviewers

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#116391

No description provided.