Viewport Compositor: Add option to exempt Grease Pencil #116425

Closed
Omar Emara wants to merge 2 commits from OmarEmaraDev/blender:viewport-compositor-no-gp into main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Member

This patch adds a new option to control if the viewport compositor will
apply on Grease Pencil objects.

This is just a test patch and is not intended for review.

This patch adds a new option to control if the viewport compositor will apply on Grease Pencil objects. This is just a test patch and is not intended for review.
Omar Emara added the
Interest
Compositing
Module
VFX & Video
labels 2023-12-21 13:09:48 +01:00
Omar Emara added 1 commit 2023-12-21 13:09:57 +01:00
buildbot/vexp-code-patch-lint Build done. Details
buildbot/vexp-code-patch-darwin-arm64 Build done. Details
buildbot/vexp-code-patch-windows-amd64 Build done. Details
buildbot/vexp-code-patch-darwin-x86_64 Build done. Details
buildbot/vexp-code-patch-linux-x86_64 Build done. Details
buildbot/vexp-code-patch-coordinator Build done. Details
e2e8fd8ab9
Viewport Compositor: Add option to exempt Grease Pencil
This patch adds a new option to control if the viewport compositor will
apply on Grease Pencil objects.

This is just a test patch and is not intended for review.
Author
Member

@blender-bot package

@blender-bot package
Member

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR116425) when ready.
Omar Emara added 1 commit 2023-12-21 13:54:25 +01:00
buildbot/vexp-code-patch-darwin-arm64 Build done. Details
buildbot/vexp-code-patch-lint Build done. Details
buildbot/vexp-code-patch-darwin-x86_64 Build done. Details
buildbot/vexp-code-patch-linux-x86_64 Build done. Details
buildbot/vexp-code-patch-windows-amd64 Build done. Details
buildbot/vexp-code-patch-coordinator Build done. Details
64e2bc51c5
Merge branch 'main' into viewport-compositor-no-gp
Author
Member

@blender-bot package

@blender-bot package
Member

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR116425) when ready.

It's not clear that this option will work for long, because there are plans to integrate grease pencil rendering more closely with EEVEE. Then it would not necessarily be an extra pass, rather you might have grease pencil objects behind transparent meshes, participating in shadows, etc.

It's not clear that this option will work for long, because there are plans to integrate grease pencil rendering more closely with EEVEE. Then it would not necessarily be an extra pass, rather you might have grease pencil objects behind transparent meshes, participating in shadows, etc.
Author
Member

@brecht I see. So you suggest to delay such changes until we know how it will pan out with the new GP rendering plans?

@brecht I see. So you suggest to delay such changes until we know how it will pan out with the new GP rendering plans?

I think so. But even leaving that aside, I imagine users want this for both viewport and final render. So the right design is probably to generate separate passes or layers, rather than having this as a viewport option.

I think so. But even leaving that aside, I imagine users want this for both viewport and final render. So the right design is probably to generate separate passes or layers, rather than having this as a viewport option.
Author
Member

Alright. For reference, the user request was this post, where the user already used passes for final rendering.

Alright. For reference, the user request was [this post](https://devtalk.blender.org/t/real-time-compositor-feedback-and-discussion/25018/496?u=omaremaradev), where the user already used passes for final rendering.
Omar Emara closed this pull request 2024-01-17 14:26:36 +01:00
Some checks failed
buildbot/vexp-code-patch-darwin-arm64 Build done.
buildbot/vexp-code-patch-lint Build done.
buildbot/vexp-code-patch-darwin-x86_64 Build done.
buildbot/vexp-code-patch-linux-x86_64 Build done.
buildbot/vexp-code-patch-windows-amd64 Build done.
buildbot/vexp-code-patch-coordinator Build done.

Pull request closed

Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#116425
No description provided.