UI: Implement a Clear Recent Files List Operator #116494

Jonas Holzman · 2023-12-23T17:35:58+01:00

Jonas Holzman commented

2023-12-23 17:35:58 +01:00

Right now, it's not possible for the user to clear the recent files list without manually editing the config/recent-files.txt file. This PR adds a simple operator to do so, placing its button at the bottom of the list, similar to the macOS system apps recent file menu. Also, to prevent the user from accidentally erasing his recent files list, this operator asks for confirmation.

Right now, it's not possible for the user to clear the recent files list without manually editing the `config/recent-files.txt` file. This PR adds a simple operator to do so, placing its button at the bottom of the list, similar to the macOS system apps recent file menu. Also, to prevent the user from accidentally erasing his recent files list, this operator asks for confirmation. ![ClearRecentFilesScreenshot.png](/attachments/915c106f-8c3b-4e0b-8cf2-9d19fac54484) <video src="/attachments/3073b973-08ab-42ea-b91f-2ab3985e2c98" title="ClearRecentFilesDemo.mp4" controls></video>

ClearRecentFilesScreenshot.png

105 KiB

ClearRecentFilesDemo.mp4

301 KiB

❤️ 1

Iliya Katushenock added this to the User Interface project 2023-12-23 17:39:47 +01:00

Jonas Holzman requested review from Harley Acheson 2023-12-23 17:42:04 +01:00

ThinkingPolygons commented

2023-12-23 18:24:56 +01:00

First-time contributor

sounds useful
can the popup confirmation be a normal dialog that appears in the middle of the window?
that thing that appear on mouse cursor is very dangerous. just accidentally click twice and its over. it should really be eradicated from blender imo

sounds useful can the popup confirmation be a normal dialog that appears in the middle of the window? that thing that appear on mouse cursor is very dangerous. just accidentally click twice and its over. it should really be eradicated from blender imo

Jonas Holzman commented

2023-12-23 19:14:28 +01:00

can the popup confirmation be a normal dialog that appears in the middle of the window?
that thing that appear on mouse cursor is very dangerous. just accidentally click twice and its over. it should really be eradicated from blender imo

Yeah I agree that this kind of quick popup style confirmation can be quite dangerous in some cases, but right now it's the standard way of asking for confirmation for these sorts of menu buttons (See File > Defaults > Load Factory Settings for example). I can't really state on whether or not these should be replaced, it might be worth opening a Design Issue about it to discuss this more in depth with UI Module members.

> can the popup confirmation be a normal dialog that appears in the middle of the window? > that thing that appear on mouse cursor is very dangerous. just accidentally click twice and its over. it should really be eradicated from blender imo Yeah I agree that this kind of quick popup style confirmation can be quite dangerous in some cases, but right now it's the standard way of asking for confirmation for these sorts of menu buttons (See `File > Defaults > Load Factory Settings` for example). I can't really state on whether or not these should be replaced, it might be worth opening a Design Issue about it to discuss this more in depth with UI Module members.

ThinkingPolygons commented

2023-12-23 19:20:06 +01:00

First-time contributor

I can't really state on whether or not these should be replaced

it will. see #104670
i just dont know why it hasnt yet

> I can't really state on whether or not these should be replaced it will. see #104670 i just dont know why it hasnt yet

Harley Acheson commented

2023-12-23 20:08:34 +01:00

it will. see #104670
i just dont know why it hasnt yet

We approve of the general idea and it just needs some code review. We'll get that in. Then an operator confirmation, like in this PR, can get a fancy dialog in just a few lines of code.

> it will. see #104670 > i just dont know why it hasnt yet We approve of the general idea and it just needs some code review. We'll get that in. Then an operator confirmation, like in this PR, can get a fancy dialog in just a few lines of code.

Harley Acheson commented

2023-12-26 19:07:29 +01:00

Did you try this with ICON_X or ICON_TRASH? It might balance it out and add more contrast?

Did you try this with ICON_X or ICON_TRASH? It might balance it out and add more contrast? ![image](/attachments/7989a75d-9b9d-49d2-8c78-b1312743ef59)

image.png

101 KiB

Jonas Holzman force-pushed clear-recent-files from 8a78ef0abe to 8473de1a3a

2023-12-28 01:52:05 +01:00

Compare

Jonas Holzman commented

2023-12-28 01:53:22 +01:00

This does improve readability indeed! I originally didn't think about adding an icon at all, following the precedent of operators in topbar submenus usually not having one, but with the operator being right below the list of blend files icons, this does help better differentiate it from the list, as well as improving horizontal balance.

I ended up going with ICON_TRASH as I felt like it conveyed the intent of completely erasing the list better, let me know what you think.

This does improve readability indeed! I originally didn't think about adding an icon at all, following the precedent of operators in topbar submenus usually not having one, but with the operator being right below the list of blend files icons, this does help better differentiate it from the list, as well as improving horizontal balance. I ended up going with `ICON_TRASH` as I felt like it conveyed the intent of completely erasing the list better, let me know what you think. ![RecentFilesIcon.png](/attachments/5fdb7b96-b62e-499e-ae6b-cb3a253ffde4)

RecentFilesIcon.png

112 KiB

Harley Acheson commented

2023-12-28 03:00:55 +01:00