Animation: fix frame snapping for the time extend transformation mode. #116542

Alexander Gavrilov · 2023-12-25T21:45:35+01:00

2023-12-25 21:45:35 +01:00

The graph editor supports an Extend transformation mode, which is
essentially Move that only affects keyframes either before or
after the current frame, based on the mouse cursor position.

This fixes a bug in this mode where it doesn't respect the snap setting.

To reproduce:

Add some keyframes, go to the graph editor.
When using Move, the keys snap to frames according to the enabled magnet button.
When using Extend, they do not - unless this fix is applied.

The graph editor supports an Extend transformation mode, which is essentially Move that only affects keyframes either before or after the current frame, based on the mouse cursor position. This fixes a bug in this mode where it doesn't respect the snap setting. --- To reproduce: * Add some keyframes, go to the graph editor. * When using Move, the keys snap to frames according to the enabled magnet button. * When using Extend, they do not - unless this fix is applied.

Alexander Gavrilov added the

Module

Animation & Rigging

label 2023-12-25 21:45:35 +01:00

Alexander Gavrilov added 1 commit 2023-12-25 21:45:41 +01:00

3c4c495c50 Animation: fix frame snapping for the time extend transformation mode.

The graph editor supports an Extend transformation mode, which is
essentially Move that only affects keyframes either before or
after the current frame, based on the mouse cursor position.

This fixes a bug in this mode where it doesn't respect the snap setting.

Alexander Gavrilov requested review from Christoph Lendenfeld 2023-12-25 21:49:18 +01:00

Alexander Gavrilov requested review from Sybren A. Stüvel 2023-12-25 21:49:29 +01:00

Christoph Lendenfeld approved these changes 2024-01-04 10:57:55 +01:00

Christoph Lendenfeld left a comment

Code and functionality looks good. thanks for the fix
When landing this, the commit title needs to be
Fix: frame snapping for the time extend transformation mode
to follow the conventions

Code and functionality looks good. thanks for the fix When landing this, the commit title needs to be `Fix: frame snapping for the time extend transformation mode` to follow the conventions

Sybren A. Stüvel approved these changes 2024-01-04 16:06:09 +01:00

Sybren A. Stüvel left a comment

Thanks!

I haven't tested it, I trust @angavrilov and @ChrisLend on that. Code LGTM.

Thanks! I haven't tested it, I trust @angavrilov and @ChrisLend on that. Code LGTM.

Alexander Gavrilov merged commit 4fe6f0b271 into main

2024-01-08 14:19:05 +01:00

Alexander Gavrilov deleted branch pr-keyframe-extend-snap

2024-01-08 14:19:08 +01:00

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Animation: fix frame snapping for the time extend transformation mode. #116542