Fix: active node not updated when using the add_reroute operator #116634

Andrew Stevenson · 2023-12-29T20:30:32+01:00

Andrew Stevenson commented

2023-12-29 20:30:32 +01:00

First-time contributor

Currently, when using the add_reroute operator, only the selected nodes are updated, and not the active node. This results in the originally active node not being highlighted, but still acting as if it is active.

Fixing this allows for adding reroutes and then renaming them directly after with F2. Currently, this renames the originally active node, rather than the reroute.

Current	Fixed

I'm not a c++ developer, so this may not be the optimal way to achieve this.

Currently, when using the `add_reroute` operator, only the selected nodes are updated, and not the active node. This results in the originally active node not being highlighted, but still acting as if it is active. Fixing this allows for adding reroutes and then renaming them directly after with F2. Currently, this renames the originally active node, rather than the reroute. <table> <tr> <td>Current</td> <td>Fixed</td> </tr> <tr> <td><video src="/attachments/79cecabc-108d-47f2-912f-f26ad81db680" title="2023-12-29 19-21-51.mp4" controls></video></td> <td><video src="/attachments/c622572d-928c-4a43-a1cd-70868cdf0e41" title="2023-12-29 19-16-48.mp4" controls></video></td> </tr> </table> I'm not a c++ developer, so this may not be the optimal way to achieve this.

2023-12-29 19-16-48.mp4

102 KiB

2023-12-29 19-21-51.mp4

102 KiB

👍 2

Andrew Stevenson added 1 commit 2023-12-29 20:30:43 +01:00

7f77b8619f Fix: active node not updated when using add_reroute operator.

This allows for adding reroutes and then renaming them directly after with F2, currently they need to be set to active manually for this to work.

I'm not a c++ developer, so this may not be the optimal way to achieve this.

Iliya Katushenock added this to the Nodes & Physics project 2023-12-29 20:40:15 +01:00

Pratik Borhade commented

2023-12-30 06:39:38 +01:00

Hi, thanks for the PR. I doubt if that's a correct solution. It would be hard to determine the active reroute node when reroutes are added to multiple links in single shift + RMB cut. And it also involves some design discussion.
I proposed patch for this problem last year, you can see the discussion at: https://archive.blender.org/developer/D15313 (#99161)
Closing.
cc @HooglyBoogly

Hi, thanks for the PR. I doubt if that's a correct solution. It would be hard to determine the active reroute node when reroutes are added to multiple links in single `shift + RMB` cut. And it also involves some design discussion. I proposed patch for this problem last year, you can see the discussion at: https://archive.blender.org/developer/D15313 (#99161) Closing. cc @HooglyBoogly

Pratik Borhade closed this pull request

2023-12-30 06:39:40 +01:00

Pull request closed

Please reopen this pull request to perform a merge.

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Fix: active node not updated when using the add_reroute operator #116634

Pull request closed