User Preferences: Numbers string 3/4 digit grouping #116710

Open

YimingWu wants to merge 1 commits from ChengduLittleA/blender:numbers-grouping into main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.

YimingWu commented

2024-01-02 14:39:01 +01:00

Member

Added the functionality for switching 3/4 digit grouping for different conventions.

A lot of eastern cultures like Chinese uses 4 digit grouping for numbers such as 1234,5678.
This change allows user more choice for readability.

BLI_str_format_int_grouped is renamed BLI_str_format_int_grouped_n and a default
value of 3 is given by the marco BLI_str_format_int_grouped to maintain the behavior of
old code.

Currently it only has 3 or 4 digit grouping, I believe there can be more formatting
styles available.

Currently affecting viewport and status bar numbers. The option is available in
User Preference > Interface > Editors section.

Added the functionality for switching 3/4 digit grouping for different conventions. A lot of eastern cultures like Chinese uses 4 digit grouping for numbers such as `1234,5678`. This change allows user more choice for readability. `BLI_str_format_int_grouped` is renamed `BLI_str_format_int_grouped_n` and a default value of 3 is given by the marco `BLI_str_format_int_grouped` to maintain the behavior of old code. Currently it only has 3 or 4 digit grouping, I believe there can be more formatting styles available. Currently affecting viewport and status bar numbers. The option is available in `User Preference > Interface > Editors` section. ![图片](/attachments/622a40ca-191f-4b84-afc7-99e6a67824d9) ![图片](/attachments/3a455771-b36a-4135-86dc-fdd92164c968)

37 KiB

29 KiB

YimingWu added the

labels 2024-01-02 14:39:01 +01:00

Iliya Katushenock added this to the User Interface project 2024-01-02 15:17:41 +01:00

Iliya Katushenock removed the

label 2024-01-02 15:17:48 +01:00

YimingWu commented

2024-01-03 04:45:24 +01:00

Author

Member

Also see D6179, ICU might be doable, but personally I think it's too heavy of an add for general processing of this format that's not used that frequently

Also see [D6179](https://archive.blender.org/developer/D6179), [ICU](https://en.wikipedia.org/wiki/International_Components_for_Unicode) might be doable, but personally I think it's too heavy of an add for general processing of this format that's not used that frequently

YimingWu force-pushed numbers-grouping from 986bbd89ad to ebbb3d242c

2024-01-03 08:46:16 +01:00

Compare

Brecht Van Lommel commented

2024-01-12 15:15:22 +01:00

Owner

Typically, this kind of thing is handled by following the locale rather than every application configuring it separately.

Would it make sense to use these when Chinese language is used, rather than having a dedicated option?

If there is a need for an option, it feels more logical to have it next to other translation settings.

Typically, this kind of thing is handled by following the locale rather than every application configuring it separately. Would it make sense to use these when Chinese language is used, rather than having a dedicated option? If there is a need for an option, it feels more logical to have it next to other translation settings.

YimingWu commented

2024-01-15 09:25:27 +01:00

Author

Member

I'd prefer for it to go with translation setting too. So I might be to setting this value in the language set callback. The language enumeration doesn't seem to hold more data. I couldn't seem to find if there there is any "table" for language-associated configurations @Harley ? Looks like all it's relevant is the text file datafiles/locale/languages. Adding extra config in there seems ugly. Any existing ways we can link extra information with each local? (Otherwise I'll just manually add a table somewhere to look up)

I'd prefer for it to go with translation setting too. So I might be to setting this value in the language set callback. The language enumeration doesn't seem to hold more data. I couldn't seem to find if there there is any "table" for language-associated configurations @Harley ? Looks like all it's relevant is the text file `datafiles/locale/languages`. Adding extra config in there seems ugly. Any existing ways we can link extra information with each local? (Otherwise I'll just manually add a table somewhere to look up)

Brecht Van Lommel commented

2024-01-15 11:08:34 +01:00

Owner

I don't know how well it will work for us, but I think this is what the locale in the C++ standard library or fmtlib is for. That is Blender would not have its own table specifying the formatting for each language, but rather get that information from or do the formatting through those APIs.

I don't know how well it will work for us, but I think this is what the locale in the C++ standard library or [fmtlib](https://fmt.dev/latest/api.html?highlight=locale#locale) is for. That is Blender would not have its own table specifying the formatting for each language, but rather get that information from or do the formatting through those APIs.

Harley Acheson commented

2024-01-15 22:37:51 +01:00

Member

My struggle here is the conflation of locale and language. There might be a default language as part of a locale, but I don't want to infer locale from language.

For example, I am in Canada so I have my own computer set to show time in 12 hour format. Changing my language in the computer, or in Blender, to French does not mean I want to change the time format to 24 hour. Similarly for the use of period or comma as decimal separator. This varies by region, and those regions may have predominant language, but this isn't tied to the language. So people in France prefer "12.000,00", regardless of language.

You might prefer four-digit large number grouping, but I'd imagine that is what you want regardless of what language selected in Blender. This is something you set in the OS once outside of Blender and we should be honoring that setting.

Yes, there are some formatting differences that are per-language but this one is per region. Just like people in India will want their large number group formatting which is like 10,00,00,000. This shouldn't change if they show Blender in English or Chinese.

As mentioned by Brecht this would most likely involve using a standard library for the formatting of these things, rather than rolling our own, but using the current locale not the one taken from the blender output language setting.

My struggle here is the conflation of locale and language. There might be a default language as part of a locale, but I don't want to infer locale from language. For example, I am in Canada so I have my own computer set to show time in 12 hour format. Changing my language in the computer, or in Blender, to French does not mean I want to change the time format to 24 hour. Similarly for the use of period or comma as decimal separator. This varies by region, and those regions may have predominant language, but this isn't tied to the language. So people in France prefer "12.000,00", regardless of language. You might prefer four-digit large number grouping, but I'd imagine that is what you want regardless of what language selected in Blender. This is something you set in the OS once outside of Blender and we should be honoring that setting. Yes, there are some formatting differences that are per-language but this one is per region. Just like people in India will want their large number group formatting which is like 10,00,00,000. This shouldn't change if they show Blender in English or Chinese. As mentioned by Brecht this would most likely involve using a standard library for the formatting of these things, rather than rolling our own, but using the current locale not the one taken from the blender output language setting.

Brecht Van Lommel commented

2024-01-16 12:53:19 +01:00

Owner

It indeed doesn't necessarily have to depend on the chosen translation. Maybe it's rather a checkbox to use system settings for formatting numbers and dates.

It indeed doesn't necessarily have to depend on the chosen translation. Maybe it's rather a checkbox to use system settings for formatting numbers and dates.

YimingWu commented

2024-01-16 15:09:15 +01:00

Author

Member

There's also a problem with system-wise formatting like in this specific case of thousand/10-thousand marker. Our systems are generally just 3-digit group anyway, the local settings do affect some stuff like use period or comma. I just tested on my machine where no matter you are using LC_ALL=zh_CN or en_US or hi_IN, printf "%'.3f\n" 123123142153415142 will give you 123,123,142,153,415,142.000.

Will test ICU and see if there's any difference, likely not. Since this is kind of a minor thing, people kinda get used to it, but it still feel weird in our languages.

There's also a problem with system-wise formatting like in this specific case of thousand/10-thousand marker. Our systems are generally just 3-digit group anyway, the local settings do affect some stuff like use period or comma. I just tested on my machine where no matter you are using `LC_ALL=zh_CN` or `en_US` or `hi_IN`, `printf "%'.3f\n" 123123142153415142` will give you `123,123,142,153,415,142.000`. Will test ICU and see if there's any difference, likely not. Since this is kind of a minor thing, people kinda get used to it, but it still feel weird in our languages.

Harley Acheson commented

2024-01-16 16:56:03 +01:00

Member

@ChengduLittleA

Note that if we go down this path, one thing we can't get for any foreseeable future is display of numbers in inputs with comma decimal delimiter, as in "1.00,99". There are quite a few reasons, mostly related to our integration with python, but also for portability of scripts. There might be some solution for this, but you should probably assume we can't do this. That might result in some uncanny valley here if some numbers are regionally formatted.

@ChengduLittleA Note that if we go down this path, one thing we can't get for any foreseeable future is display of numbers in inputs with comma decimal delimiter, as in "1.00,99". There are quite a few reasons, mostly related to our integration with python, but also for portability of scripts. There might be some solution for this, but you should probably assume we can't do this. That might result in some uncanny valley here if some numbers are regionally formatted.

Merge conflict checking is in progress. Try again in few moments.

View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u numbers-grouping:ChengduLittleA-numbers-grouping

git checkout ChengduLittleA-numbers-grouping

Sign in to join this conversation.

No reviewers

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#116710

No description provided.