UI: Attemps to improve FH drag-n-drop support #116724
No reviewers
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Code Documentation
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#116724
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "guishe/blender:test-dnd-fh"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
#116047 Adds support to drag-n-drop to file handlers, however current implementation
depends a lot in how imports operators are implemented, for example alembic just imports
one file per call and current implementation will only support drag-n-drop one file at
the time. Also the implementation only supports to call one file handler for drag-n-drop
This pr contains 2 attempts to improve current workflow
The first allows user to select a file handler and select what files to use withthe active file handler and allows to set the import settings, this just imports the files selected
with the active file handler
The second allows user to chose a file handler for each extension type and allow
to set the import settings for each extension type, this allows to run a call to all imports
operator in a single click.
Few concerns:
I think proposal 2 is good with some tweaks.
Marking as request changes.
a3d305ec60
to4216461129
Everything done, but I don't know what label to put in case it's not a single fh (see
.txt .py
)Edit: Best cases scenarios that would not be a problem (only one exporter for usd,ply...) , maybe thinking more about fh that supports images or videos
will do some cleanup
@Brecht Can you ping the bot for a package build?
I think it's almost finished, there are a couple of things that I have included just for testing that can be removed
@blender-bot package
Package build started. Download here when ready.
Now only proposal 2 remains in the code.
Apart from that, I think it is ready for review
It's a good question, I don't have an obvious solution. To me the current state of falling back to the file extension seems reasonable.
Minor suggestion for the UI:
Maybe @Harley or @pablovazquez have an opinion on this UI as well.
I'm mostly with Brecht here....
If the outer border is removed, and also the border around the information line at the bottom then it is nicely separated from the rest.
However, I struggle with the informational text at the the bottom. The button indicates that you will import all 12 files. Therefore I think I'd want that text to show the totals, not just the amount on this page. If this were to remain only a count of the files of the type on this page I think I'd want that above the settings, not below.
So maybe something like this, although perhaps with some removal of redundant "files" text?
Added also small change
Removed changes that were just for testing and are in other pr (the confirm button will show ok by now, until !117143)
Additional diff with file handlers for test
Since we can now change the title, this can also be customized:
Checkout
From your project repository, check out a new branch and test the changes.