Fix #115977: Regression: Sculpt: Clay Thumb brush extra offset #116738

Sergey Sharybin · 2024-01-03T11:15:49+01:00

Sergey Sharybin commented

2024-01-03 11:15:49 +01:00

The refactor in cf9fcbf24e used the wrong area coordinate for the
clay brush: the original code used ss->cache->location as the
area_co passed to the bush callback, and the new code after refactor
used the area_co which was calculated as a displaced brush plane.

The calculation of the displaced brush area plane as area_co seems
to be unused, and reason for it is not really clear.

This change only restores the area_co passed to the brush callback
to the value it used to be prior to the refactor.

The refactor in cf9fcbf24e used the wrong area coordinate for the clay brush: the original code used `ss->cache->location` as the `area_co` passed to the bush callback, and the new code after refactor used the `area_co` which was calculated as a displaced brush plane. The calculation of the displaced brush area plane as `area_co` seems to be unused, and reason for it is not really clear. This change only restores the `area_co` passed to the brush callback to the value it used to be prior to the refactor.

Sergey Sharybin added 1 commit 2024-01-03 11:15:56 +01:00

Fix #115977 : Regression: Sculpt: Clay Thumb brush extra offset bb88268b48

The refactor in cf9fcbf24e used the wrong area coordinate for the
clay brush: the original code used `ss->cache->location` as the
`area_co` passed to the bush callback, and the new code after refactor
used the `area_co` which was calculated as a displaced brush plane.

The calculation of the displaced brush area plane as `area_co` seems
to be unused, and reason for it is not really clear.

This change only restores the `area_co` passed to the brush callback
to the value it used to be prior to the refactor.

Sergey Sharybin merged commit 46f3f53b16 into main

2024-01-03 11:16:31 +01:00

Sergey Sharybin deleted branch fix_115977

2024-01-03 11:16:33 +01:00

Sergey Sharybin referenced this issue from a commit

2024-01-03 11:16:35 +01:00

Fix #115977: Regression: Sculpt: Clay Thumb brush extra offset

Arye Ramaty referenced this issue from a commit

2024-01-21 15:37:37 +01:00

Fix #115977: Regression: Sculpt: Clay Thumb brush extra offset

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Fix #115977: Regression: Sculpt: Clay Thumb brush extra offset #116738