Update gamma correction table to take into account Freetype's own recomandation #116755

RyuukkDev · 2024-01-03T17:47:04+01:00

RyuukkDev commented

2024-01-03 17:47:04 +01:00

First-time contributor

Freetype recomands using 1.8 for the gamma, this will fix blurry fonts on 1080p screen with low DPI

https://freetype.org/freetype2/docs/hinting/text-rendering-general.html

Freetype recomands using 1.8 for the gamma, this will fix blurry fonts on 1080p screen with low DPI https://freetype.org/freetype2/docs/hinting/text-rendering-general.html

RyuukkDev added 1 commit 2024-01-03 17:47:13 +01:00

f63f3ca23d Update gamma correction table to take into account Freetype's own recomandation

Brecht Van Lommel requested review from Harley Acheson 2024-01-12 14:48:51 +01:00

Brecht Van Lommel commented

2024-01-12 14:50:16 +01:00

Ca you demonstrate the improvement with some screenshots?

Drawing involves many steps, so it's not always obvious that change things in one place doesn't counteract or duplicate something that's already done elsewhere.

Ca you demonstrate the improvement with some screenshots? Drawing involves many steps, so it's not always obvious that change things in one place doesn't counteract or duplicate something that's already done elsewhere.

Harley Acheson commented

2024-01-12 18:14:45 +01:00

@RyuukkDev

I am not saying that this PR is incorrect as it could very well be an improvement. I just wanted to add some background to this.

That referenced FreeType page isn't really a "Update 2024", but a page from 2015. Although 1.8 is the recommended gamma value on that page, we are currently using a generally-accepted compromise value of 1.43, as described in this 2019 article: https://www.puredevsoftware.com/blog/2019/01/22/sub-pixel-gamma-correct-font-rendering/

This is basically for historical reasons because so many operating system and apps were not doing any gamma correction for so long that many fonts have been created thicker than needed to avoid looking too thin at small sizes. In short, many fonts were made by designers who were working on systems with 0 gamma and so appear the wrong weight when gamma is properly applied.

But things change and 1.8 could very well be a better value for us. As long as it can be demonstrated to look better at our typical font sizes, window sizes, and theme colors, using our current font and most obvious replacements. I would not worry about high-dpi displays as this value will just have no noticeable effect when the pixels are that small. And note that I personally would prefer to use 1.8 so I am hoping this change is demonstratably better.

But this has to be demonstrated. The best way is to simply take screenshots of an area of blender with the two different gamma values, , and possibly also include magnified sections of each, showing improvement. And include this in this thread.

If you cannot, don't wish to, or don't know how to demonstrate this well I can also spend some time comparing and paste comparisons here. But I'd rather you did it so that I can spend time other things.

@RyuukkDev I am not saying that this PR is incorrect as it could very well be an improvement. I just wanted to add some background to this. That referenced FreeType page isn't really a "Update 2024", but a page from 2015. Although 1.8 is the recommended gamma value on that page, we are currently using a generally-accepted compromise value of 1.43, as described in this 2019 article: https://www.puredevsoftware.com/blog/2019/01/22/sub-pixel-gamma-correct-font-rendering/ This is basically for historical reasons because so many operating system and apps were not doing any gamma correction for so long that many fonts have been created thicker than needed to avoid looking too thin at small sizes. In short, many fonts were made by designers who were working on systems with 0 gamma and so appear the wrong weight when gamma is properly applied. But things change and 1.8 could very well be a better value for us. As long as it can be demonstrated to look better at our typical font sizes, window sizes, and theme colors, using our current font and most obvious replacements. I would not worry about high-dpi displays as this value will just have no noticeable effect when the pixels are that small. And note that I personally would prefer to use 1.8 so I am hoping this change is demonstratably better. But this has to be demonstrated. The best way is to simply take screenshots of an area of blender with the two different gamma values, , and possibly also include magnified sections of each, showing improvement. And include this in this thread. If you cannot, don't wish to, or don't know how to demonstrate this well I can also spend some time comparing and paste comparisons here. But I'd rather you did it so that I can spend time other things.

Raul Fernandez Hernandez added the

Status

Needs Info from Developers

label 2024-02-29 17:51:16 +01:00

Merge conflict checking is in progress. Try again in few moments.

View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u gamma:RyuukkDev-gamma

git checkout RyuukkDev-gamma

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Update gamma correction table to take into account Freetype's own recomandation #116755

Checkout