Alembic: export render resolution on cameras #116782

Merged
Philipp Oeser merged 2 commits from lichtwerk/blender:116375 into main 2024-01-04 17:49:41 +01:00
Member

Blender's cameras don't have specific resolution configured to them,
instead they use the scene's resolution.
This is a problem when exporting a camera using Alembic. Other software
(like Houdini) expects the resolution parameters on the camera itself.

So now store the scene's resolution on each camera that is exported.
Since this is not part of the concept of a camera in alembic itself,
export these as userProperties in a way other software can read this.

Fixes #116375

Blender's cameras don't have specific resolution configured to them, instead they use the scene's resolution. This is a problem when exporting a camera using Alembic. Other software (like Houdini) expects the resolution parameters on the camera itself. So now store the scene's resolution on each camera that is exported. Since this is not part of the concept of a camera in alembic itself, export these as `userProperties` in a way other software can read this. Fixes #116375
Philipp Oeser added 1 commit 2024-01-04 14:20:24 +01:00
buildbot/vexp-code-patch-lint Build done. Details
buildbot/vexp-code-patch-darwin-arm64 Build done. Details
buildbot/vexp-code-patch-darwin-x86_64 Build done. Details
buildbot/vexp-code-patch-linux-x86_64 Build done. Details
buildbot/vexp-code-patch-windows-amd64 Build done. Details
buildbot/vexp-code-patch-coordinator Build done. Details
6d990b582e
Alembic: export render resolution on cameras
Blender's cameras don't have specific resolution configured to them,
instead they use the scene's resolution.
This is a problem when exporting a camera using Alembic. Other software
(like Houdini) expects the resolution parameters on the camera itself.

So now store the scene's resolution on each camera that is exported.
Since this is not part of the concept of a camera in alembic itself,
export these as `userProperties` in a way other software can read this.

Fixes #116375
Philipp Oeser added this to the Pipeline, Assets & IO project 2024-01-04 14:20:41 +01:00
Philipp Oeser added the
Interest
Alembic
label 2024-01-04 14:20:47 +01:00
Philipp Oeser requested review from Sybren A. Stüvel 2024-01-04 14:20:52 +01:00
Philipp Oeser requested review from Brecht Van Lommel 2024-01-04 14:21:01 +01:00
Author
Member

@blender-bot package

@blender-bot package
Member

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR116782) when ready.
Brecht Van Lommel requested changes 2024-01-04 15:45:12 +01:00
@ -47,0 +49,4 @@
/* Export scene render resolution on cameras as userProperties, for other software (e.g.
* Houdini). */
OFloatProperty render_resx(abc_custom_data_container_, "resx");
OFloatProperty render_resy(abc_custom_data_container_, "resy");

It's a bit strange to use float instead of an int here, but from the bug report it seems that's how it's done by other software so seems fine.

It's a bit strange to use float instead of an int here, but from the bug report it seems that's how it's done by other software so seems fine.
brecht marked this conversation as resolved
@ -47,0 +50,4 @@
* Houdini). */
OFloatProperty render_resx(abc_custom_data_container_, "resx");
OFloatProperty render_resy(abc_custom_data_container_, "resy");
Scene *scene = DEG_get_input_scene(args_.depsgraph);

Use DEG_get_evaluated_scene, the resolution could be animated or otherwise modified in the evaluated scene.

Use `DEG_get_evaluated_scene`, the resolution could be animated or otherwise modified in the evaluated scene.
Author
Member

I changed that now.
Just to make sure: You would not think to export this for every time sample, right?
I thought render resolution is not supposed to be animated?
If we want this per time sample, it has to be modified slightly (this is what I had in the beginning), right now this is only written "once" to the camera.

I changed that now. Just to make sure: You would not think to export this for every time sample, right? I thought render resolution is not supposed to be animated? If we want this per time sample, it has to be modified slightly (this is what I had in the beginning), right now this is only written "once" to the camera.

It seems it can not be animated now, though a Python script could still modify it. In general, it's just good practice to use evaluated data for exporting, so we don't have to make that assumption.

I don't think we need to support exporting animated render resolutions to Alembic files.

It seems it can not be animated now, though a Python script could still modify it. In general, it's just good practice to use evaluated data for exporting, so we don't have to make that assumption. I don't think we need to support exporting animated render resolutions to Alembic files.
brecht marked this conversation as resolved
Philipp Oeser added 1 commit 2024-01-04 15:56:42 +01:00
Brecht Van Lommel approved these changes 2024-01-04 16:03:30 +01:00
Sybren A. Stüvel approved these changes 2024-01-04 16:18:54 +01:00
Sybren A. Stüvel left a comment
Member

Looks good to me, thanks.

Looks good to me, thanks.
Philipp Oeser merged commit 5412bd48a9 into main 2024-01-04 17:49:41 +01:00
Philipp Oeser deleted branch 116375 2024-01-04 17:49:43 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#116782
No description provided.